From: Anssi Hannula <anssi.hannula@iki.fi>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jari Vanhala <ext-jari.vanhala@nokia.com>,
Linux Input <linux-input@vger.kernel.org>
Subject: Re: [RFC] ff-memless instant starting
Date: Fri, 25 Dec 2009 01:52:42 +0200 [thread overview]
Message-ID: <4B33FECA.1050407@iki.fi> (raw)
In-Reply-To: <20091223193805.GB4525@core.coreip.homeip.net>
On 23.12.2009 21:38, Dmitry Torokhov wrote:
> On Wed, Dec 23, 2009 at 03:31:14PM +0200, Jari Vanhala wrote:
>> Hi,
>>
>> Looks like starting effect with low HZ machine takes considerably time
>> due need to wait for system timer. Simplest way to make things faster is
>> to do calculation for effect always instantly, like in stopping, but
>> this makes starting multiple effects more costly.
>>
>> Other solution would be making it a module parameter, so behavior could
>> be controlled per machine. Optimize possible cost or speed. I attached
>> small patch which will do that.
>>
>> If starting priority of individual effect is needed to controlled, you
>> probably need to add flag for that to effect itself... I don't know
>> which way FF-api is developing, so this could be either good or bad
>> thing.
>>
>> Any opinions or suggestions? Other than rising HZ. =)
>>
>
> I think we should just start playing the effect immediately, without any
> additional module parameters. I'll queue such patch unless I hear
> otherwise from Anssi.
Indeed that is ok, no need for a module parameter.
--
Anssi Hannula
prev parent reply other threads:[~2009-12-24 23:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 13:31 [RFC] ff-memless instant starting Jari Vanhala
2009-12-23 19:38 ` Dmitry Torokhov
2009-12-24 23:52 ` Anssi Hannula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B33FECA.1050407@iki.fi \
--to=anssi.hannula@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=ext-jari.vanhala@nokia.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).