linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Input: serio - re-add thaw (and add freeze)
Date: Wed, 03 Feb 2010 18:59:54 +0000	[thread overview]
Message-ID: <4B69C7AA.7000904@tuffmail.co.uk> (raw)

633aae2 "Input: i8042 - switch to using dev_pm_ops"
removed handling for PMSG_THAW, causing obscure breakage.

It can break if you press keys during hibernation,
which causes subsequent keypresses to be lost -
so you can't cancel s2disk by pressing backspace -
and then just before system poweroff you get
"psmouse.c: Failed to deactivate mouse".

So let's add the thaw handler back.

Also set the freeze handler.  It looks like PMSG_FREEZE
didn't do anything in the past, but I think that must
have been an oversight.

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
---
 drivers/input/serio/i8042.c |    2 ++
 drivers/input/serio/serio.c |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index d84a36e..9599766 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -1164,6 +1164,8 @@ static int i8042_pm_restore(struct device *dev)
 static const struct dev_pm_ops i8042_pm_ops = {
 	.suspend	= i8042_pm_reset,
 	.resume		= i8042_pm_restore,
+	.freeze		= i8042_pm_reset,
+	.thaw		= i8042_pm_restore,
 	.poweroff	= i8042_pm_reset,
 	.restore	= i8042_pm_restore,
 };
diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index e0f3018..2e8f544 100644
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -949,6 +949,8 @@ static int serio_resume(struct device *dev)
 static const struct dev_pm_ops serio_pm_ops = {
 	.suspend	= serio_suspend,
 	.resume		= serio_resume,
+	.freeze		= serio_suspend,
+	.thaw		= serio_resume,
 	.poweroff	= serio_suspend,
 	.restore	= serio_resume,
 };
-- 
1.6.3.3




             reply	other threads:[~2010-02-03 19:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 18:59 Alan Jenkins [this message]
2010-02-03 19:11 ` [PATCH] Input: serio - re-add thaw (and add freeze) Dmitry Torokhov
2010-02-04 10:22   ` Alan Jenkins
2010-02-16 16:48     ` Alan Jenkins
2010-02-16 17:22       ` Dmitry Torokhov
2010-02-25  7:03         ` Pavel Machek
2010-02-25  7:38           ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B69C7AA.7000904@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).