From: Pekka Sarnila <sarnila@adit.fi>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Jiri Slaby <jirislaby@gmail.com>, Antti Palosaari <crope@iki.fi>,
mchehab@infradead.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes
Date: Thu, 04 Feb 2010 16:07:36 +0200 [thread overview]
Message-ID: <4B6AD4A8.9080101@adit.fi> (raw)
In-Reply-To: <alpine.LNX.2.00.1002041425050.15395@pobox.suse.cz>
Yes, my comment maybe criticizes more the basic architectural structure
of usb putting it's own work up to higher layer. The only practical
thing is that, if there is a non-HID device suffering from that
FULLSPEED problem, the quirk won't help it. Anyway in current kernel
structure usb layer doesn't handle endpoint setup at all, thus it simply
can not do the job.
Pekka
Jiri Kosina wrote:
>
> Yes, I still think what I have stated before, that this should be properly
> handled in the USB stack.
>
> On the other hand, in usbhid driver we do a lot of USB-specific
> lower-level things anyway, so it's technically more-or-less OK to apply
> the quirk there as well (and that's why I have accepted it back then).
>
next prev parent reply other threads:[~2010-02-04 14:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1264007972-6261-1-git-send-email-jslaby@suse.cz>
[not found] ` <4B5CDB53.6030009@iki.fi>
[not found] ` <4B5D6098.7010700@gmail.com>
[not found] ` <4B5DDDFB.5020907@iki.fi>
[not found] ` <alpine.LRH.2.00.1001261406010.15694@twin.jikos.cz>
2010-02-04 10:31 ` [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes Jiri Slaby
2010-02-04 12:04 ` Mauro Carvalho Chehab
2010-02-04 12:53 ` Jiri Slaby
2010-02-04 13:41 ` Mauro Carvalho Chehab
2010-02-04 13:51 ` Jiri Slaby
2010-02-04 14:05 ` Mauro Carvalho Chehab
2010-02-05 14:02 ` Jarod Wilson
2010-02-04 14:26 ` Mauro Carvalho Chehab
2010-02-04 13:23 ` Pekka Sarnila
2010-02-04 13:27 ` Jiri Kosina
2010-02-04 14:07 ` Pekka Sarnila [this message]
2010-02-08 4:13 ` Greg KH
2010-02-04 14:04 ` Mauro Carvalho Chehab
2010-02-04 15:05 ` Pekka Sarnila
2010-02-04 17:13 ` Mauro Carvalho Chehab
2010-02-05 14:31 ` Pekka Sarnila
2010-02-04 18:14 ` Dmitry Torokhov
2010-02-04 18:33 ` Jiri Slaby
2010-02-04 18:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6AD4A8.9080101@adit.fi \
--to=sarnila@adit.fi \
--cc=crope@iki.fi \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).