From: Rafi Rubin <rafi@seas.upenn.edu>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, jkosina@suse.cz, chatty@enac.fr
Subject: Re: [PATCH 3/4] hid-ntrig.c Split multi and single touch.
Date: Thu, 11 Feb 2010 22:10:35 -0500 [thread overview]
Message-ID: <4B74C6AB.1010704@seas.upenn.edu> (raw)
In-Reply-To: <20100212004247.GB6394@core.coreip.homeip.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
>> + input_event(input, EV_ABS, ABS_MT_TOUCH_MAJOR, 0);
>> + input_event(input, EV_ABS, ABS_MT_TOUCH_MINOR, 0);
>> + input_mt_sync(input);
>> + }
>> + }
>
> Where's the final input_sync()? And if hid does it for us (I think it does)
> then syncs above are not needed.
It seems the normal input_sync calls are unnecessary for the single touch device.
The mt syncs are necessary to separate each contact. And since we are caching the
contacts we need to emit those. The final normal input_sync is handled by hid.
On a side note, once I pulled the st input syncs, the mt device stopped getting them.
I had to undo the blocking of CONTACTCOUNT which restores the normal syncs from hid.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkt0xqgACgkQwuRiAT9o6081+wCfe5K5LRJXr0jORoTJPOVwCrXT
V7YAn1ijdSwMSyenvPU9wy3QfJyodDJS
=UZmW
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-02-12 3:10 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 0:19 [PATCH 1/4] HID: hid-ntrig add multi input quirk and clean up Rafi Rubin
2010-02-12 0:19 ` [PATCH 2/4] hid-ntrig.c: removed unnecessary tool switching Rafi Rubin
2010-02-12 0:19 ` [PATCH 3/4] hid-ntrig.c Split multi and single touch Rafi Rubin
2010-02-12 0:19 ` [PATCH 4/4] hid-ntrig: Contact tracking Rafi Rubin
2010-02-12 0:42 ` [PATCH 3/4] hid-ntrig.c Split multi and single touch Dmitry Torokhov
2010-02-12 3:10 ` Rafi Rubin [this message]
2010-02-12 8:09 ` Dmitry Torokhov
2010-02-12 19:56 ` Rafi Rubin
2010-02-12 10:41 ` Jiri Kosina
2010-02-12 0:36 ` [PATCH 1/4] HID: hid-ntrig add multi input quirk and clean up Dmitry Torokhov
2010-02-12 0:45 ` Rafi Rubin
2010-02-12 1:03 ` Rafi Rubin
2010-02-12 1:20 ` Dmitry Torokhov
2010-02-12 0:37 ` Rafi Rubin
2010-02-12 3:14 ` Rafi Rubin
2010-02-12 3:14 ` [PATCH 2/4] hid-ntrig.c: removed unnecessary tool switching Rafi Rubin
2010-02-12 3:14 ` [PATCH 3/4] hid-ntrig.c Split multi and single touch Rafi Rubin
2010-02-12 3:14 ` [PATCH 4/4] hid-ntrig: Contact tracking Rafi Rubin
2010-02-20 8:29 ` Mohamed Ikbel Boulabiar
[not found] ` <45cc95261002200025m378e1a80rec09bde5673a6060@mail.gmail.com>
2010-02-20 17:48 ` Rafi Rubin
2010-02-12 8:13 ` [PATCH 3/4] hid-ntrig.c Split multi and single touch Dmitry Torokhov
2010-02-12 23:16 ` Rafi Rubin
2010-02-13 2:13 ` [PATCH] hid-ntrig.c Multitouch cleanup and fix Rafi Rubin
2010-02-13 2:24 ` Rafi Rubin
2010-02-16 12:50 ` Jiri Kosina
2010-03-09 21:01 ` Henrik Rydberg
2010-03-09 21:17 ` Rafi Rubin
2010-03-09 21:19 ` Jiri Kosina
2010-03-09 22:03 ` Stéphane Chatty
2010-03-09 22:25 ` Henrik Rydberg
2010-03-09 22:42 ` Mohamed Ikbel Boulabiar
2010-03-09 23:08 ` Henrik Rydberg
2010-03-09 23:17 ` Dmitry Torokhov
2010-03-09 23:26 ` Henrik Rydberg
2010-03-11 4:30 ` Peter Hutterer
2010-03-11 5:36 ` Mohamed Ikbel Boulabiar
2010-03-11 6:25 ` Peter Hutterer
2010-03-11 9:42 ` Stéphane Chatty
2010-03-09 22:27 ` Dmitry Torokhov
2010-03-09 22:32 ` Rafi Rubin
2010-03-09 22:54 ` Stéphane Chatty
2010-03-09 22:12 ` Rafi Rubin
2010-03-09 22:39 ` Henrik Rydberg
2010-03-09 21:59 ` Henrik Rydberg
2010-03-09 22:11 ` Stéphane Chatty
2010-03-09 22:29 ` Henrik Rydberg
2010-03-09 22:44 ` Stéphane Chatty
2010-03-09 22:27 ` Rafi Rubin
2010-03-09 23:23 ` Henrik Rydberg
2010-03-09 23:38 ` Rafi Rubin
2010-03-09 23:42 ` Dmitry Torokhov
2010-03-10 0:32 ` Rafi Rubin
2010-03-10 3:47 ` Dmitry Torokhov
2010-03-10 4:40 ` Rafi Rubin
2010-03-10 8:38 ` [PATCH] hid: ntrig touch events rafi
2010-03-10 15:04 ` Jiri Kosina
2010-03-18 20:19 ` Rafi Rubin
2010-03-19 8:44 ` Jiri Kosina
2010-03-19 14:12 ` Rafi Rubin
2010-02-16 12:49 ` [PATCH 2/4] hid-ntrig.c: removed unnecessary tool switching Jiri Kosina
2010-02-12 3:15 ` [PATCH 1/4] HID: hid-ntrig add multi input quirk and clean up Rafi Rubin
2010-02-16 12:49 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B74C6AB.1010704@seas.upenn.edu \
--to=rafi@seas.upenn.edu \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).