linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hid-ntrig.c: Single touch mode tap
@ 2010-02-16 15:22 Rafi Rubin
  2010-02-16 15:30 ` Rafi Rubin
  0 siblings, 1 reply; 2+ messages in thread
From: Rafi Rubin @ 2010-02-16 15:22 UTC (permalink / raw)
  To: linux-input, jkosina, dmitry.torokhov, rafi

Add DOUBLETAP to events emitted when in single touch only mode.

Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
---
 drivers/hid/hid-ntrig.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
index f6f882d..3234c72 100644
--- a/drivers/hid/hid-ntrig.c
+++ b/drivers/hid/hid-ntrig.c
@@ -165,6 +165,8 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
 			 * to emit a normal (X, Y) position
 			 */
 			if (!nd->reading_mt) {
+				input_report_key(input, BTN_TOOL_DOUBLETAP,
+						 (nd->confidence != 0));
 				input_event(input, EV_ABS, ABS_X, nd->x);
 				input_event(input, EV_ABS, ABS_Y, nd->y);
 			}
-- 
1.6.6.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hid-ntrig.c: Single touch mode tap
  2010-02-16 15:22 [PATCH] hid-ntrig.c: Single touch mode tap Rafi Rubin
@ 2010-02-16 15:30 ` Rafi Rubin
  0 siblings, 0 replies; 2+ messages in thread
From: Rafi Rubin @ 2010-02-16 15:30 UTC (permalink / raw)
  To: Rafi Rubin; +Cc: linux-input, jkosina, dmitry.torokhov

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I just got some feedback from a user with a single touch firmware letting me
know he wasn't seeing the DOUBLETAP events after the previous patch set.

That was a side effect of dropping old mapping for confidence.  The confidence
mapping may be fine for st mode but causes problems in mt mode.

This seemed simpler than complicating the mapping further or messing with the
handling of HD_DG_CONFIDENCE.

Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkt6ugMACgkQwuRiAT9o609YfgCdGYgDeu+UIGSUd6AJqJxMBR33
BbAAoJQvbBXKID3ukN5qjkqhzQ6n+iS0
=xLHv
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-16 15:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-16 15:22 [PATCH] hid-ntrig.c: Single touch mode tap Rafi Rubin
2010-02-16 15:30 ` Rafi Rubin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).