From: "Németh Márton" <nm127@freemail.hu>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Jiri Kosina <jkosina@suse.cz>,
Linux Input <linux-input@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Platform Driver x86 <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] Input: scancode in get/set_keycodes should be unsigned
Date: Sun, 28 Feb 2010 07:44:32 +0100 [thread overview]
Message-ID: <4B8A10D0.2020802@freemail.hu> (raw)
In-Reply-To: <20100228061310.GA765@core.coreip.homeip.net>
Hi,
Dmitry Torokhov wrote:
> The HID layer has some scan codes of the form 0xffbc0000 for logitech
> devices which do not work if scancode is typed as signed int, so we need
> to switch to unsigned int instead. While at it keycode being signed does
> not make much sense either.
Are the scan codes and key codes always 4 bytes long? Then the u32 data
type could be used to take 16 bit (or 64 bit) processors also into
consideration.
Regards,
Márton Németh
next prev parent reply other threads:[~2010-02-28 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-28 6:13 [PATCH] Input: scancode in get/set_keycodes should be unsigned Dmitry Torokhov
2010-02-28 6:44 ` Németh Márton [this message]
2010-02-28 7:05 ` Dmitry Torokhov
2010-02-28 8:40 ` Németh Márton
2010-03-01 14:52 ` Matthew Garrett
2010-03-08 11:08 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8A10D0.2020802@freemail.hu \
--to=nm127@freemail.hu \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).