From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?N=E9meth_M=E1rton?= <nm127@freemail.hu>
Subject: Re: [PATCH] Input: scancode in get/set_keycodes should be unsigned
Date: Sun, 28 Feb 2010 07:44:32 +0100
Message-ID: <4B8A10D0.2020802@freemail.hu>
References: <20100228061310.GA765@core.coreip.homeip.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-media-owner@vger.kernel.org>
In-Reply-To: <20100228061310.GA765@core.coreip.homeip.net>
Sender: linux-media-owner@vger.kernel.org
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>, Mauro Carvalho Chehab <mchehab@redhat.com>, Jiri Kosina <jkosina@suse.cz>, Linux Input <linux-input@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, Platform Driver x86 <platform-driver-x86@vger.kernel.org>
List-Id: linux-input@vger.kernel.org

Hi,
Dmitry Torokhov wrote:
> The HID layer has some scan codes of the form 0xffbc0000 for logitech
> devices which do not work if scancode is typed as signed int, so we n=
eed
> to switch to unsigned int instead. While at it keycode being signed d=
oes
> not make much sense either.

Are the scan codes and key codes always 4 bytes long? Then the u32 data
type could be used to take 16 bit (or 64 bit) processors also into
consideration.

Regards,

	M=E1rton N=E9meth