linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rafi Rubin <rafi@seas.upenn.edu>
To: Micki Balanga <micki@n-trig.com>
Cc: jkosina@suse.cz, chatty@enac.fr, peterhuewe@gmx.de,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rafi Rubin <rafi@seas.upenn.edu>
Subject: Re: [PATCH] USB: N-trig Finger Pen Multitouch fix
Date: Sun, 07 Mar 2010 20:41:38 -0500	[thread overview]
Message-ID: <4B9455D2.7080502@seas.upenn.edu> (raw)
In-Reply-To: <48A28051AC6D7A48B64F28272458190301AF29@Exchange-IL.n-trig.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

One other note:

> +                                               input_report_abs(input,
> ABS_MT_TRACKING_ID, nt_rpt->finger_id);

I pulled the tracking id to conform to
	Documentation/input/multi-touch-protocol.txt
which states that unreliable tracking ids should not be passed to the user
space.  So unless you have done something to fix the broken tracking that I've
been seeing, we should leave it out for now.

Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuUVdIACgkQwuRiAT9o608ymwCgpGXXnsWcEd2C+WaBxVpnla/e
xYgAoK68Yyvl2RLzqhWVGk9tKOFpsEwI
=O+8/
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2010-03-08  1:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <48A28051AC6D7A48B64F28272458190301AF29@Exchange-IL.n-trig.com>
2010-03-08  1:34 ` [PATCH] USB: N-trig Finger Pen Multitouch fix Rafi Rubin
2010-03-08 12:25   ` Stéphane Chatty
2010-03-08 13:11   ` Micki Balanga
2010-03-09  8:06     ` Dmitry Torokhov
2010-03-09 10:27     ` Jiri Kosina
2010-03-08  1:41 ` Rafi Rubin [this message]
2010-03-08 12:51 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9455D2.7080502@seas.upenn.edu \
    --to=rafi@seas.upenn.edu \
    --cc=chatty@enac.fr \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=micki@n-trig.com \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).