From: Rafi Rubin <rafi@seas.upenn.edu>
To: mickib1@gmail.com
Cc: jkosina@suse.cz, chatty@enac.fr, peterhuewe@gmx.de,
micki@n-trig.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, rafi@seas.upenn.edu
Subject: Re: [PATCH 6/7] HID: N-trig MTM Driver fix And cleanup patch 6
Date: Mon, 08 Mar 2010 20:20:13 -0500 [thread overview]
Message-ID: <4B95A24D.2090903@seas.upenn.edu> (raw)
In-Reply-To: <1268082827-2680-6-git-send-email-micki@n-trig.com>
> static const struct hid_device_id ntrig_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_TOUCH_SCREEN),
> - .driver_data = NTRIG_DUPLICATE_USAGES },
> + .driver_data = NTRIG_USB_DEVICE_ID },
The vendor and device id are in the first field "HID_USB_DEVICE", driver
data is for flags, not id. Its merely a coincidence that they are the
same in this case.
The duplicate usages tells hid to let you have more than one "x" and "y"
axis. Otherwise each finger gets a new set (the second finger gets "z"
and "rx" and so on).
> static int __init ntrig_init(void)
> {
> + info("N-trig Driver Version 1.6\n");
Perhaps you mean:
MODULE_VERSION("1.06");
next prev parent reply other threads:[~2010-03-09 1:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 21:13 [PATCH 1/7] HID: N-trig MTM Driver fix and cleanup patch 1 mickib1
2010-03-08 21:13 ` [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2 mickib1
2010-03-08 21:13 ` [PATCH 3/7] HID: N-trig MTM Driver fix And cleanup patch 3 mickib1
2010-03-08 21:13 ` [PATCH 4/7] HID: N-trig MTM Driver fix And cleanup Patch 4 mickib1
2010-03-08 21:13 ` [PATCH 5/7] HID: N-trig MTM Driver fix And cleanup patch 5 mickib1
2010-03-08 21:13 ` [PATCH 6/7] HID: N-trig MTM Driver fix And cleanup patch 6 mickib1
2010-03-09 1:20 ` Rafi Rubin [this message]
2010-03-09 10:15 ` Jiri Kosina
2010-03-09 1:29 ` [PATCH 5/7] HID: N-trig MTM Driver fix And cleanup patch 5 Rafi Rubin
2010-03-09 1:10 ` [PATCH 4/7] HID: N-trig MTM Driver fix And cleanup Patch 4 Rafi Rubin
2010-03-09 1:07 ` [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2 Rafi Rubin
2010-03-09 15:43 ` Stéphane Chatty
2010-03-09 0:34 ` [PATCH 1/7] HID: N-trig MTM Driver fix and cleanup patch 1 Rafi Rubin
2010-03-09 0:50 ` Rafi Rubin
2010-03-09 10:11 ` Jiri Kosina
2010-03-09 8:43 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B95A24D.2090903@seas.upenn.edu \
--to=rafi@seas.upenn.edu \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micki@n-trig.com \
--cc=mickib1@gmail.com \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).