From: Graham Gower <graham.gower@gmail.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: UCB1400: Passing IRQ through platform_data
Date: Tue, 23 Mar 2010 14:01:27 +1030 [thread overview]
Message-ID: <4BA8360F.8080208@gmail.com> (raw)
In-Reply-To: <201003230401.48660.marek.vasut@gmail.com>
Marek Vasut wrote:
> Dne Út 23. března 2010 02:39:19 Graham Gower napsal(a):
>> The ucb1400_core is registered with driver_register.
>>
>> I have grepped my tree and the only places I see "ucb12400_core" are in a
>> couple of arm board files and in my board file. Mine is commented out, and
>> I definitely still get the probe being called.
>>
>> I added dump_stack() to the probe function.
>>
>> [<80014f50>] dump_stack+0x8/0x34
>> [<801b1dec>] ucb1400_core_probe+0x48/0x1ac
>> [<801ab114>] driver_probe_device+0x128/0x254
>> [<801aa440>] bus_for_each_drv+0x60/0xb0
>> [<801ab3e4>] device_attach+0x60/0x88
>> [<801aa234>] bus_probe_device+0x30/0x54
>> [<801a8a74>] device_add+0x368/0x4f0
>> [<80210970>] snd_ac97_dev_register+0xa0/0xd8
>> [<801ef6e8>] snd_device_register_all+0x44/0x80
>> [<801eb2f4>] snd_card_register+0x64/0x18c
>> [<80216f3c>] snd_soc_instantiate_cards+0x368/0x5c4
>> [<80217214>] soc_probe+0x7c/0xc4
>> [<801ab114>] driver_probe_device+0x128/0x254
>> [<801aa440>] bus_for_each_drv+0x60/0xb0
>> [<801ab3e4>] device_attach+0x60/0x88
>> [<801aa234>] bus_probe_device+0x30/0x54
>> [<801a8a74>] device_add+0x368/0x4f0
>> [<801aca5c>] platform_device_add+0x14c/0x1b8
>> [<803813a4>] quokka_init+0x98/0xec
>> [<800180f0>] do_one_initcall+0x68/0x200
>> [<80371328>] kernel_init+0xc4/0x164
>> [<8001ac2c>] kernel_thread_helper+0x10/0x18
>
> Aren't you probing it from some driver or something ?
I register an ac97 platform driver from an arch_initcall function. It looks
like the ucb1400_core driver is probed once the ac97 device is found.
>> This has nothing to do with the irq number that I'm passing (which is not
>> 123 anyway). The ucb1400_core's dev->platform_data pointer is NULL.
>
> We know it is NULL ... that's because you're not passing it.
When I attempt to pass it via a platform device with platform_add_devices, it
is still NULL. I suspected that it was NULL because the ucb1400_core
isn't a platform_driver - thus I commented out the platform device
for ucb1400_core in my arch_initcall and sure enough the probe was still
being called.
-Graham
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-03-23 3:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BA70831.1040606@gmail.com>
2010-03-22 13:13 ` UCB1400: Passing IRQ through platform_data Marek Vasut
2010-03-22 22:44 ` Graham Gower
2010-03-23 0:59 ` Marek Vasut
2010-03-23 1:25 ` H Hartley Sweeten
2010-03-23 1:39 ` Graham Gower
2010-03-23 2:08 ` H Hartley Sweeten
2010-03-23 3:13 ` Marek Vasut
2010-03-24 5:07 ` Graham Gower
2010-03-23 3:01 ` Marek Vasut
2010-03-23 3:31 ` Graham Gower [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA8360F.8080208@gmail.com \
--to=graham.gower@gmail.com \
--cc=hartleys@visionengravers.com \
--cc=linux-input@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).