From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH] Teach drivers/media/IR/ir-raw-event.c to use durations Date: Fri, 09 Apr 2010 21:43:10 -0300 Message-ID: <4BBFC99E.6010707@infradead.org> References: <20100408161000.GA23119@hardeman.nu> <1270848998.3038.47.camel@palomino.walls.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:42049 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753084Ab0DJAnP (ORCPT ); Fri, 9 Apr 2010 20:43:15 -0400 In-Reply-To: <1270848998.3038.47.camel@palomino.walls.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Andy Walls Cc: =?UTF-8?B?RGF2aWQgSMOkcmRlbWFu?= , linux-input@vger.kernel.org, linux-media@vger.kernel.org Andy Walls wrote: > On Thu, 2010-04-08 at 18:10 +0200, David H=C3=A4rdeman wrote: >=20 >> With this patch: >> >> s64 int's are used to represent pulse/space durations in ns >=20 > If performing divides on 64 bit numbers, please check to make sure yo= ur > code compiles, links, and loads on a 32-bit system. >=20 > We've had problems in the past in where gcc will build the module to > reference __udivdi3 under 32-bit kernels; but that symbol is not in t= he > kernel. Good catch! > Search for 'do_div' in: >=20 > linux/drivers/media/video/cx18/cx18-av-core.c >=20 > for a simple example divide that works on both 64 and 32 bit machines= =2E Unfortunately, not all gcc versions complain about the lack of the __ud= ivi32 library. Some (like the one I run on my desktop), will add some inlined assembler code for it, instead of requiring some library to do the divi= sion. We'll likely only discover such bugs only after sending the code to lin= ux-next (done later yesterday - but I suspect that it were pulled only today fr= om my tree) and receiving a complain for the ones that run those robots th= at test hundreds of different CONFIG_foo options. So, I suspect that we'll have some of such complaints by tomorrow... --=20 Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html