From: Henrik Rydberg <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Éric Piel" <E.A.B.Piel@tudelft.nl>,
"Florian Ragwitz" <rafl@debian.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 2/2] elantech: Report multitouch with proper ABS_MT messages
Date: Wed, 05 May 2010 20:01:45 +0200 [thread overview]
Message-ID: <4BE1B289.2040204@euromail.se> (raw)
In-Reply-To: <20100505163832.GA7337@core.coreip.homeip.net>
Dmitry Torokhov wrote:
>> @@ -253,7 +253,6 @@ static void elantech_report_absolute_v2(struct psmouse *psmouse)
>>
>> /* byte 0: n1 n0 . . . . R L */
>> fingers = (packet[0] & 0xc0) >> 6;
>> - input_report_key(dev, BTN_TOUCH, fingers != 0);
>
> Mousedev works a tad better if BTN_TOUCH is reported first. Otherwise
> looks good.
>
> Henrik, should we report "tool width" as ABS_MT_WIDTH_MAJOR?
I might be missing some context here, I see no prior use of width in the driver.
The answer is either ABS_MT_TOUCH_MAJOR or ABS_MT_WIDTH_MAJOR depending on how
the width is actually computed. Generally, it makes little sense to have
ABS_MT_WIDTH_MAJOR (width of approaching finger) without ABS_MT_TOUCH_MAJOR
(width of touching finger), but it is ok to have only ABS_MT_TOUCH_MAJOR. Things
like thumb detection requires both values to be reliable.
Henrik
next prev parent reply other threads:[~2010-05-05 18:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 12:20 [PATCH 2/2] elantech: Report multitouch with proper ABS_MT messages Éric Piel
2010-05-05 16:38 ` Dmitry Torokhov
2010-05-05 17:06 ` Éric Piel
2010-05-05 17:15 ` Dmitry Torokhov
2010-05-05 17:36 ` Éric Piel
2010-05-05 18:03 ` Henrik Rydberg
2010-05-05 18:05 ` Florian Ragwitz
2010-05-05 18:11 ` Henrik Rydberg
2010-05-05 18:25 ` Dmitry Torokhov
2010-05-05 18:29 ` Henrik Rydberg
2010-05-05 20:51 ` Dmitry Torokhov
2010-05-05 18:01 ` Henrik Rydberg [this message]
2010-05-05 18:14 ` Éric Piel
2010-05-05 18:26 ` Henrik Rydberg
2010-05-05 18:35 ` Éric Piel
2010-05-05 19:06 ` Henrik Rydberg
2010-05-05 21:19 ` Éric Piel
2010-05-05 22:15 ` Henrik Rydberg
2010-05-05 22:53 ` Éric Piel
2010-05-06 8:49 ` Stéphane Chatty
2010-05-06 9:26 ` Mohamed Ikbel Boulabiar
[not found] ` <g2t45cc95261005060217nfbde1177j1dc97028a3b53c3c@mail.gmail.com>
2010-05-06 11:40 ` Henrik Rydberg
2010-05-06 9:22 ` Hennerich, Michael
2010-05-06 11:38 ` Henrik Rydberg
2010-05-05 23:00 ` Éric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE1B289.2040204@euromail.se \
--to=rydberg@euromail.se \
--cc=E.A.B.Piel@tudelft.nl \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rafl@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).