From: Robert Schedel <r.schedel@yahoo.de>
To: dhprince.devel@yahoo.co.uk, Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.34-rc7 v4] HID: hid-samsung: add support for Creative Desktop Wireless 6000
Date: Mon, 17 May 2010 19:11:25 +0200 [thread overview]
Message-ID: <4BF178BD.2000209@yahoo.de> (raw)
In-Reply-To: <4BF11D9F.80605@yahoo.co.uk>
Hello,
sorry for one late observation:
On 17.05.2010 12:42, Don Prince wrote:
> Add support for the multimedia buttons of the Creative Desktop Wireless
> 6000 keyboard/mouse combo which are not currently handled by the
> default/samsung HID driver.
>
> Signed-off-by: Don Prince <dhprince-devel@yahoo.co.uk>
>
> ---
>
> Added comments as requested by Robert Schedel <r.schedel@yahoo.de>
>
> As requested by Jiri Kosina, made key mapping code more concise
> i.e. ignored checkpatch.pl's wingeing about code style.
[...]
> + switch (usage->hid & HID_USAGE) {
> + /* report 2 */
> + case 0x0b5: samsung_kbd_mouse_map_key_clear(KEY_NEXTSONG); break;
> + case 0x0b6: samsung_kbd_mouse_map_key_clear(KEY_PREVIOUSSONG); break;
> + case 0x0b7: samsung_kbd_mouse_map_key_clear(KEY_STOPCD); break;
> + case 0x0cd: samsung_kbd_mouse_map_key_clear(KEY_PLAYPAUSE); break;
> + case 0x0e2: samsung_kbd_mouse_map_key_clear(KEY_MUTE); break;
> + case 0x0e9: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEUP); break;
> + case 0x0ea: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEDOWN); break;
Those seven are identical to hid-input.c mapping (HUT 1.1 compliant) and could simply be deleted. Daisy chaining via default case below, right?
> + case 0x183: samsung_kbd_mouse_map_key_clear(KEY_MEDIA); break;
> + case 0x195: samsung_kbd_mouse_map_key_clear(KEY_EMAIL); break;
> + case 0x196: samsung_kbd_mouse_map_key_clear(KEY_CALC); break;
> + case 0x197: samsung_kbd_mouse_map_key_clear(KEY_COMPUTER); break;
> + case 0x22b: samsung_kbd_mouse_map_key_clear(KEY_SEARCH); break;
> + case 0x22c: samsung_kbd_mouse_map_key_clear(KEY_WWW); break;
> + case 0x22d: samsung_kbd_mouse_map_key_clear(KEY_BACK); break;
> + case 0x22e: samsung_kbd_mouse_map_key_clear(KEY_FORWARD); break;
> + case 0x22f: samsung_kbd_mouse_map_key_clear(KEY_FAVORITES); break;
> + case 0x230: samsung_kbd_mouse_map_key_clear(KEY_REFRESH); break;
> + case 0x231: samsung_kbd_mouse_map_key_clear(KEY_STOP); break;
> + default:
> + return 0;
Regards,
Robert Schedel
next prev parent reply other threads:[~2010-05-17 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 10:42 [PATCH 2.6.34-rc7 v4] HID: hid-samsung: add support for Creative Desktop Wireless 6000 Don Prince
2010-05-17 11:38 ` Jiri Kosina
2010-05-17 17:11 ` Robert Schedel [this message]
2010-05-17 18:54 ` Don Prince
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF178BD.2000209@yahoo.de \
--to=r.schedel@yahoo.de \
--cc=dhprince.devel@yahoo.co.uk \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).