From: Rafi Rubin <rafi@seas.upenn.edu>
To: Micki Balanga <micki@n-trig.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
chatty@enac.fr, dhprince-devel@yahoo.co.uk,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: Add support to new N-trig firwmare
Date: Mon, 21 Jun 2010 02:14:32 -0400 [thread overview]
Message-ID: <4C1F0348.8000804@seas.upenn.edu> (raw)
In-Reply-To: <48A28051AC6D7A48B64F28272458190338280A@Exchange-IL.n-trig.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/21/10 01:06, Micki Balanga wrote:
> Hi Jiri
> We have some new product so I have to update the patch,
> When I update my git branch I didn't see the changes regarding N-trig
> Product id. If you can insert this patch, if there a problem with the
> patch
> Let me know and hi will update it
> Thank you
> Micki
>
>
> -----Original Message-----
> From: Jiri Kosina [mailto:jkosina@suse.cz]
> Sent: Saturday, June 05, 2010 6:42 PM
> To: Micki Balanga
> Cc: chatty@enac.fr; dhprince-devel@yahoo.co.uk;
> linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Rafi Rubin
> Subject: RE: [PATCH] HID: Add support to new N-trig firwmare
>
> On Fri, 4 Jun 2010, Micki Balanga wrote:
>
>> Hi Jiri,
>> Attach the patch via file.
>> (Also fix 3 warning: please , no space before tabs)
>
> Thanks Micki, I have applied the patch.
>
Micki, looks like there are a couple of accidental whitespace modifications:
- -#define USB_VENDOR_ID_ADS_TECH 0x06e1
+#define USB_VENDOR_ID_ADS_TECH 0x06e1
- -#define USB_VENDOR_ID_EZKEY 0x0518
+#define USB_VENDOR_ID_EZKEY 0x0518
Also, in the list of product ids, did you mean to skip 2?
Jiri, is there a better way than listing each device individually?
Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkwfA0UACgkQwuRiAT9o60+M9QCfQJcJ7pMo9TOY5vYgfK6Yq16d
nD8AoK+l5sVJKAUEpyYEEANnCFCNm/zr
=IFqR
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-06-21 6:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 5:11 [PATCH] HID: Add support to new N-trig firwmare Micki Balanga
2010-06-04 9:17 ` Jiri Kosina
2010-06-04 9:57 ` Rafi Rubin
[not found] ` <48A28051AC6D7A48B64F28272458190326E03E@Exchange-IL.n-trig.com>
2010-06-05 15:42 ` Jiri Kosina
2010-06-21 5:06 ` Micki Balanga
2010-06-21 6:14 ` Rafi Rubin [this message]
2010-06-21 6:39 ` Micki Balanga
2010-06-21 7:55 ` Rafi Rubin
2010-06-21 9:48 ` Jiri Kosina
2010-06-21 10:09 ` Micki Balanga
2010-06-21 11:43 ` Jiri Kosina
2010-06-21 12:24 ` Micki Balanga
2010-06-21 12:25 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1F0348.8000804@seas.upenn.edu \
--to=rafi@seas.upenn.edu \
--cc=chatty@enac.fr \
--cc=dhprince-devel@yahoo.co.uk \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micki@n-trig.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).