From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 2/9] IR: minor fixes: Date: Wed, 28 Jul 2010 13:01:21 -0300 Message-ID: <4C505451.8030809@redhat.com> References: <1280330051-27732-1-git-send-email-maximlevitsky@gmail.com> <1280330051-27732-3-git-send-email-maximlevitsky@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755494Ab0G1QBR (ORCPT ); Wed, 28 Jul 2010 12:01:17 -0400 In-Reply-To: <1280330051-27732-3-git-send-email-maximlevitsky@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Maxim Levitsky Cc: lirc-list@lists.sourceforge.net, Jarod Wilson , linux-input@vger.kernel.org, linux-media@vger.kernel.org Em 28-07-2010 12:14, Maxim Levitsky escreveu: > * lirc: Don't propagate reset event to userspace > * lirc: Remove strange logic from lirc that would make first sample always be pulse > * Make TO_US macro actualy print what it should. > > Signed-off-by: Maxim Levitsky > --- > drivers/media/IR/ir-core-priv.h | 3 +-- > drivers/media/IR/ir-lirc-codec.c | 14 ++++++++------ > drivers/media/IR/ir-raw-event.c | 3 +++ > 3 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/IR/ir-core-priv.h b/drivers/media/IR/ir-core-priv.h > index babd520..8ce80e4 100644 > --- a/drivers/media/IR/ir-core-priv.h > +++ b/drivers/media/IR/ir-core-priv.h > @@ -76,7 +76,6 @@ struct ir_raw_event_ctrl { > struct lirc_codec { > struct ir_input_dev *ir_dev; > struct lirc_driver *drv; > - int lircdata; > } lirc; > }; > > @@ -104,7 +103,7 @@ static inline void decrease_duration(struct ir_raw_event *ev, unsigned duration) > ev->duration -= duration; > } > > -#define TO_US(duration) (((duration) + 500) / 1000) > +#define TO_US(duration) ((duration) / 1000) It is better to keep rounding the duration to its closest value. Cheers, Mauro