linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: lirc-list@lists.sourceforge.net,
	Jarod Wilson <jarod@wilsonet.com>,
	linux-input@vger.kernel.org, linux-media@vger.kernel.org,
	Christoph Bartelmus <lirc@bartelmus.de>
Subject: Re: [PATCH 0/9 v3] IR: few fixes, additions and ENE driver
Date: Fri, 30 Jul 2010 16:33:06 -0300	[thread overview]
Message-ID: <4C5328F2.8040404@redhat.com> (raw)
In-Reply-To: <1280489933-20865-1-git-send-email-maximlevitsky@gmail.com>

Em 30-07-2010 08:38, Maxim Levitsky escreveu:
> Hi,
> 
> This is mostly same patchset.
> 
> I addressed the comments of Andy Walls.
> 
> Now IR decoding is done by a separate thread, and this fixes
> the race, and unnesesary performance loss due to it.
> 
> Best regards,
> 	Maxim Levitsky
> 

Hmm... some change at this changeset is trying to divide a 64 bits integer
at the LIRC driver. This is causing the following error:

Jul 30 16:45:23 agua kernel: [23834.179871] lirc_dev: IR Remote Control driver registered, major 251 
Jul 30 16:45:23 agua kernel: [23834.181884] ir_lirc_codec: Unknown symbol __udivdi3 (err 0)

you should, instead use do_div for doing that. Another fix would be to define the timeout
constants as int or u32.

Cheers,
Mauro

  parent reply	other threads:[~2010-07-30 19:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30 11:38 [PATCH 0/9 v3] IR: few fixes, additions and ENE driver Maxim Levitsky
2010-07-30 11:38 ` [PATCH 01/13] IR: Kconfig fixes Maxim Levitsky
2010-07-30 11:38 ` [PATCH 02/13] IR: minor fixes: Maxim Levitsky
2010-07-30 11:38 ` [PATCH 03/13] IR: replace spinlock with mutex Maxim Levitsky
2010-07-30 11:38 ` [PATCH 04/13] IR: fix locking in ir_raw_event_work Maxim Levitsky
2010-07-30 11:38 ` [PATCH 05/13] IR: JVC: make repeat work Maxim Levitsky
2010-07-30 11:38 ` [PATCH 06/13] IR: nec decoder: fix repeat Maxim Levitsky
2010-07-30 19:36   ` Mauro Carvalho Chehab
2010-07-30 19:54     ` Maxim Levitsky
2010-07-30 11:38 ` [PATCH 07/13] IR: NECX: support repeat Maxim Levitsky
2010-07-30 11:38 ` [PATCH 08/13] IR: Allow not to compile keymaps in Maxim Levitsky
2010-07-30 11:38 ` [PATCH 09/13] IR: add helper function for hardware with small o/b buffer Maxim Levitsky
2010-07-30 11:38 ` [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver) Maxim Levitsky
2010-07-30 21:22   ` Christoph Bartelmus
2010-07-30 22:01     ` Maxim Levitsky
2010-07-31  8:10       ` Christoph Bartelmus
2010-07-31  9:35         ` Maxim Levitsky
2010-07-30 11:38 ` [PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found Maxim Levitsky
2010-07-30 11:38 ` [PATCH 12/13] STAGING: remove lirc_ene0100 driver Maxim Levitsky
2010-07-30 11:38 ` [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it Maxim Levitsky
2010-07-30 19:33 ` Mauro Carvalho Chehab [this message]
2010-07-30 19:52   ` [PATCH 0/9 v3] IR: few fixes, additions and ENE driver Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C5328F2.8040404@redhat.com \
    --to=mchehab@redhat.com \
    --cc=jarod@wilsonet.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lirc-list@lists.sourceforge.net \
    --cc=lirc@bartelmus.de \
    --cc=maximlevitsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).