From: "Éric Piel" <E.A.B.Piel@tudelft.nl>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Chris Bagwell <chris@cnpbagwell.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Florian Ragwitz <rafl@debian.org>
Subject: Re: [PATCH 7/7] elantech: average the two coordinates when 2 fingers
Date: Mon, 02 Aug 2010 15:23:43 +0200 [thread overview]
Message-ID: <4C56C6DF.2040106@tudelft.nl> (raw)
In-Reply-To: <4C56C213.2010605@euromail.se>
Op 02-08-10 15:03, Henrik Rydberg schreef:
> On 08/02/2010 02:46 PM, Éric Piel wrote:
>
> [...]
>
>>>
>>> We can do better in the sense that since the device cannot comply with MT-A, we
>>> can do as close as possible to MT-B with less cpu usage. But frankly, the best
>>> solution at this stage seems to be to drop MT handling altogether, since there
>>> does not seem to be any plan to use it.
>> Ah, this alternative solution is a bit boring ;-) In addition it's not
>> compatible with my own master plan to eventually have the "pinch to
>> zoom" and "rotate to rotate" gestures work on my laptop, like in Windows ;-)
>
>
> Since rotational symmetry is what prevents us from implementing proper MT
> support, it is not likely going to work anyways.
Well, yes, in Windows to do the rotation gesture, they "suggest" you to
keep one finger on the bottom left, and rotate only the other finger.
It's kind of fake, but it works perfectly in practice. You just have to
know about it.
>> So, let's agree on just the two patches I'm going to send to support
>> "better than nothing" MT-protocol for now. When, later, someone has
>> better ideas, he can send patches to improve MT-protocol
>> support/compliance. Fine?
>
>
> No. I think it is fair to say we tried to make it work properly, but the (known)
> information about the device is simply not enough. As long as MT does not work
> properly, there is no point in adding it at all - in particular not an elaborate
> solution. I can see that zoom would work even with a poor MT implementation, but
> that is not what the MT protocol is about. Maybe one day someone will find the
> missing information somewhere in the packets.
>
> For your usecase, perhaps one should add ABS_ZOOM etcetera instead, and patch up
> synaptics to use those values.
Detecting the pinch gesture in-kernel? In addition to me not knowing how
to do gesture recognition, I doubt Dmitry would ever accept such a
patch, and Peter Hutterer would probably not enjoy a lot either the
patch for synaptics.
That's why I like the idea of reporting MT events as well as we can (the
user will know that on his device some gestures are limited), and the
rest of the stack can stay completely standard.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-02 13:23 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 20:59 [PATCH 0/7] elantech: various improvements for 6-byte protocol Éric Piel
2010-06-21 21:01 ` [PATCH 1/7] elantech: Describe further the protocol Éric Piel
2010-06-21 21:02 ` [PATCH 2/7] [NEEDS TEST] elantech: discard the first 2 positions reports for some firmwares Éric Piel
2010-06-21 21:03 ` [PATCH 3/7] elantech: distinguish various hardware/firmware versions Éric Piel
2010-06-21 21:04 ` [PATCH 4/7] elantech: implement data check for 6-byte protocol Éric Piel
2010-06-21 21:05 ` [PATCH 6/7] elantech: export pressure and width when supported Éric Piel
2010-06-21 21:06 ` [PATCH 7/7] elantech: average the two coordinates when 2 fingers Éric Piel
2010-07-21 3:36 ` Dmitry Torokhov
2010-07-30 18:55 ` Éric Piel
2010-07-30 21:01 ` Henrik Rydberg
2010-07-30 21:41 ` Éric Piel
2010-07-31 9:28 ` Henrik Rydberg
2010-07-31 9:33 ` Dmitry Torokhov
2010-07-31 12:49 ` Henrik Rydberg
2010-07-31 23:00 ` Éric Piel
2010-08-01 7:52 ` Henrik Rydberg
2010-07-31 19:56 ` Chris Bagwell
[not found] ` <AANLkTi=cEEx-5eQPbRYvMMaECvXKQ+i-e0Eaw_g4JY7=@mail.gmail.com>
2010-07-31 23:04 ` Éric Piel
2010-08-01 9:37 ` Henrik Rydberg
2010-08-01 11:28 ` Éric Piel
2010-08-01 13:57 ` Henrik Rydberg
2010-08-02 8:17 ` Éric Piel
2010-08-02 10:02 ` Henrik Rydberg
2010-08-02 11:12 ` Éric Piel
2010-08-02 11:22 ` Henrik Rydberg
2010-08-02 11:33 ` Éric Piel
2010-08-02 11:46 ` Henrik Rydberg
2010-08-02 12:13 ` Éric Piel
2010-08-02 12:29 ` Henrik Rydberg
2010-08-02 12:46 ` Éric Piel
2010-08-02 13:03 ` Henrik Rydberg
2010-08-02 13:23 ` Éric Piel [this message]
2010-08-02 14:12 ` Henrik Rydberg
2010-08-02 16:39 ` Dmitry Torokhov
2010-08-02 17:15 ` Henrik Rydberg
2010-08-08 22:51 ` Éric Piel
2010-08-08 22:52 ` [PATCH 07/10] elantech: Report multitouch with proper ABS_MT messages Éric Piel
2010-08-08 22:53 ` [PATCH 08/10] elantech: track finger to distinguish coordinates in 2-finger report Éric Piel
2010-08-08 22:54 ` [PATCH 09/10] elantech: remove support for proprietary X driver Éric Piel
2010-08-08 22:55 ` [PATCH 10/10] elantech: don't take into account the border size in the calculations Éric Piel
2010-08-02 16:26 ` [PATCH 7/7] elantech: average the two coordinates when 2 fingers Dmitry Torokhov
2010-08-02 17:05 ` Henrik Rydberg
2010-08-01 7:36 ` Henrik Rydberg
2010-06-21 21:07 ` [PATCH 5/7] elantech: report position also with 3 fingers Éric Piel
2010-07-21 3:38 ` Dmitry Torokhov
2010-07-30 18:37 ` Éric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C56C6DF.2040106@tudelft.nl \
--to=e.a.b.piel@tudelft.nl \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rafl@debian.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).