From: Jason Wessel <jason.wessel@windriver.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
David Airlie <airlied@linux.ie>,
David Miller <davem@davemloft.net>,
Fenghua Yu <fenghua.yu@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Russell King <linux@arm.linux.org.uk>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 2/3] Input: sysrq - drop tty argument form handle_sysrq()
Date: Wed, 04 Aug 2010 06:25:07 -0500 [thread overview]
Message-ID: <4C594E13.3000204@windriver.com> (raw)
In-Reply-To: <20100804075906.30647.97136.stgit@localhost.localdomain>
On 08/04/2010 02:59 AM, Dmitry Torokhov wrote:
> Sysrq operations do not accept tty argument anymore so no need to pass
> it to us.
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
>
Looks fine to me. The kernel debugger was passing NULL anyway because
A) it was not going to be easy to figure out the tty at the time, and B)
the sysrq was not using the tty at the lowest level.
Acked-by: Jason Wessel <jason.wessel@windriver.com>
next prev parent reply other threads:[~2010-08-04 11:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 7:58 [PATCH 0/3] SysRq: do not pass tty argument around Dmitry Torokhov
2010-08-04 7:59 ` [PATCH 1/3] Input: sysrq - drop tty argument from sysrq ops handlers Dmitry Torokhov
2010-08-04 8:33 ` Benjamin Herrenschmidt
2010-08-04 9:09 ` Alan Cox
2010-08-05 1:59 ` Benjamin Herrenschmidt
2010-08-04 12:03 ` Jason Wessel
2010-08-05 2:03 ` Benjamin Herrenschmidt
2010-08-04 7:59 ` [PATCH 2/3] Input: sysrq - drop tty argument form handle_sysrq() Dmitry Torokhov
2010-08-04 11:25 ` Jason Wessel [this message]
2010-08-04 7:59 ` [PATCH 3/3] USB: drop tty argument from usb_serial_handle_sysrq_char() Dmitry Torokhov
2010-08-04 11:25 ` Jason Wessel
2010-08-04 9:11 ` [PATCH 0/3] SysRq: do not pass tty argument around Alan Cox
2010-08-04 19:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C594E13.3000204@windriver.com \
--to=jason.wessel@windriver.com \
--cc=airlied@linux.ie \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=fenghua.yu@intel.com \
--cc=gregkh@suse.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=schwidefsky@de.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).