From: Jiri Slaby <jirislaby@gmail.com>
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: dmitry.torokhov@gmail.com, jkosina@suse.cz,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
micki@n-trig.com, rydberg@euromail.se, chatty@enac.fr
Subject: Re: [PATCH] identify firmware version
Date: Thu, 02 Sep 2010 10:03:24 +0200 [thread overview]
Message-ID: <4C7F5A4C.5040700@gmail.com> (raw)
In-Reply-To: <4C7EEBEE.5030203@seas.upenn.edu>
On 09/02/2010 02:12 AM, Rafi Rubin wrote:
>
>
> On 09/01/2010 04:12 PM, Jiri Slaby wrote:
>> On 09/01/2010 11:48 AM, Rafi Rubin wrote:
>>> --- a/drivers/hid/hid-ntrig.c
>>> +++ b/drivers/hid/hid-ntrig.c
>>> @@ -90,6 +90,26 @@ struct ntrig_data {
>>> };
>>>
>>>
>>> +/*
>>> + * This function converts the 4 byte raw firmware code into
>>> + * a string containing 5 comma separated numbers.
>>> + */
>>> +static int ntrig_version_string(unsigned char *raw, char *buf)
>>> +{
>>> + __u8 a = (raw[1]& 0b00001110)>> 1;
>>> + __u8 b = (raw[0]& 0b00111100)>> 2;
>>> + __u8 c = ((raw[0]& 0b00000011)<< 3) | ((raw[3]&
>>> 0b11100000)>> 5);
>>> + __u8 d = ((raw[3]& 0b00000111)<< 3) | ((raw[2]&
>>> 0b11100000)>> 5);
>>> + __u8 e = raw[2]& 0b00000111;
>>
>> This won't compile with gcc 3.4 which we still support. Maybe time to
>> kill the support?
>>
>> ...
>
> Why not?
Beacuse it's a gnu extension added in gcc 4.3. (I though it's in gcc 4.0
initially, but it's not. So you cannot use it in the kernel code at all.)
regards,
--
js
next prev parent reply other threads:[~2010-09-02 8:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 4:54 hid-ntrig documentation and firmware id Rafi Rubin
2010-08-26 4:54 ` [PATCH 1/4] Adding documention Rafi Rubin
2010-08-27 12:06 ` Henrik Rydberg
2010-08-29 19:52 ` Rafi Rubin
2010-08-30 13:25 ` Jiri Kosina
2010-08-26 4:54 ` [PATCH 2/4] a bit of whitespace cleanup Rafi Rubin
2010-08-26 4:54 ` [PATCH 3/4] identify firmware version Rafi Rubin
2010-08-27 12:01 ` Henrik Rydberg
2010-08-29 19:55 ` Rafi Rubin
2010-08-26 4:54 ` [PATCH 4/4] firmware sysfs node Rafi Rubin
2010-08-27 12:09 ` Henrik Rydberg
2010-08-27 16:34 ` Dmitry Torokhov
2010-08-31 2:06 ` Rafi Rubin
2010-09-01 2:06 ` Dmitry Torokhov
2010-09-01 9:48 ` [PATCH] identify firmware version Rafi Rubin
2010-09-01 10:04 ` Rafi Rubin
2010-09-01 12:27 ` Henrik Rydberg
2010-09-01 20:12 ` Jiri Slaby
2010-09-02 0:12 ` Rafi Rubin
2010-09-02 8:03 ` Jiri Slaby [this message]
2010-09-02 18:00 ` Rafi Rubin
2010-09-02 18:11 ` Rafi Rubin
2010-09-06 16:42 ` Rafi Rubin
2010-09-06 19:48 ` Dmitry Torokhov
2010-09-06 21:22 ` Jiri Slaby
2010-09-06 23:32 ` Rafi Rubin
2010-09-06 23:36 ` Dmitry Torokhov
2010-09-07 6:54 ` Jiri Slaby
2010-09-08 9:47 ` Jiri Kosina
2010-09-08 15:42 ` Rafi Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7F5A4C.5040700@gmail.com \
--to=jirislaby@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micki@n-trig.com \
--cc=rafi@seas.upenn.edu \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).