From: Trilok Soni <tsoni@codeaurora.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rabin Vincent <rabin.vincent@stericsson.com>,
Sundar R IYER <sundar.iyer@stericsson.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>
Subject: Re: [PATCH] input: add support for PowerOn(PonKey) button on the AB8500 MFD
Date: Fri, 03 Sep 2010 01:23:55 +0530 [thread overview]
Message-ID: <4C8000D3.3060903@codeaurora.org> (raw)
In-Reply-To: <20100902172222.GA17386@core.coreip.homeip.net>
Hi Dmitry,
On 9/2/2010 10:52 PM, Dmitry Torokhov wrote:
>
>>>
>>> I'll change it to use normal interrupts locally, no need to resubmit.
>>
>> Changing it to request_irq() will cause it to fail, because __setup_irq
>> will error out if this is a nested thread interrupt and no interrupt
>> thread is specified. request_any_context_irq() should work, if you
>> would like to get rid of explicitly asking for a threaded irq.
>>
>
> OK, request_any_context_irq() it is then.
Though request_any_context_irq() would work here, but I would still
prefer to use the request_threaded_irq(..) because power-on key functionality
is in-built to this PMIC chip and it will always be threaded it seems. No new
thread will be created because they did the right thing in their PMIC core
irq code it seems.
We could prefer the request_any_context_irq(...) when we are using the line
(say gpio) coming out of this PMIC and used by generic device driver where
the another h/w design could have memory mapped gpio for the same device driver.
Better to keep this driver with request_threaded_irq(..) only.
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-09-02 19:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 7:35 [PATCH] input: add support for PowerOn(PonKey) button on the AB8500 MFD Sundar Iyer
2010-09-01 16:51 ` Dmitry Torokhov
2010-09-02 6:55 ` Rabin Vincent
2010-09-02 17:22 ` Dmitry Torokhov
2010-09-02 19:53 ` Trilok Soni [this message]
2010-09-02 20:24 ` Dmitry Torokhov
2010-09-03 5:16 ` Trilok Soni
2010-09-03 16:43 ` Dmitry Torokhov
2010-09-03 7:10 ` Trilok Soni
2010-09-03 7:20 ` Sundar R IYER
2010-09-03 7:54 ` Trilok Soni
2010-09-03 16:40 ` Dmitry Torokhov
2010-09-03 19:06 ` Trilok Soni
2010-09-06 3:11 ` Sundar R IYER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8000D3.3060903@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rabin.vincent@stericsson.com \
--cc=sameo@linux.intel.com \
--cc=sundar.iyer@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).