From: Trilok Soni <tsoni@codeaurora.org>
To: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: dmitry.torokhov@gmail.com, sameo@linux.intel.com,
linux-input@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com
Subject: Re: [PATCH] input: add support for PowerOn(PonKey) button on the AB8500 MFD
Date: Fri, 03 Sep 2010 12:40:51 +0530 [thread overview]
Message-ID: <4C809F7B.2020807@codeaurora.org> (raw)
In-Reply-To: <1283326551-13751-1-git-send-email-sundar.iyer@stericsson.com>
Hi Sundar,
> +
> + info->idev->name = "AB8500 POn(PowerOn) Key";
nit-pick: having spaces in the name would create hard time parsing it. Though it all
depends on the userspace framework.
> +
> +static struct platform_driver ab8500_ponkey_driver = {
> + .driver = {
> + .name = "ab8500-poweron-key",
> + .owner = THIS_MODULE,
> + },
> + .probe = ab8500_ponkey_probe,
> + .remove = __devexit_p(ab8500_ponkey_remove),
It is not must for this driver to go through, but what would be the behaviour of
pwr-key on suspend and resume? Do you want power key to wakeup the system from sleep?
OR don't want to make it as wakeup source?
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-09-03 7:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 7:35 [PATCH] input: add support for PowerOn(PonKey) button on the AB8500 MFD Sundar Iyer
2010-09-01 16:51 ` Dmitry Torokhov
2010-09-02 6:55 ` Rabin Vincent
2010-09-02 17:22 ` Dmitry Torokhov
2010-09-02 19:53 ` Trilok Soni
2010-09-02 20:24 ` Dmitry Torokhov
2010-09-03 5:16 ` Trilok Soni
2010-09-03 16:43 ` Dmitry Torokhov
2010-09-03 7:10 ` Trilok Soni [this message]
2010-09-03 7:20 ` Sundar R IYER
2010-09-03 7:54 ` Trilok Soni
2010-09-03 16:40 ` Dmitry Torokhov
2010-09-03 19:06 ` Trilok Soni
2010-09-06 3:11 ` Sundar R IYER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C809F7B.2020807@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sundar.iyer@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).