From: Henrik Rydberg <rydberg@euromail.se>
To: Ping Cheng <pingc@wacom.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Chris Bagwell <chris@cnpbagwell.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] input: wacom: Add a quirk for lowres Bamboo devices
Date: Fri, 03 Sep 2010 14:59:29 +0200 [thread overview]
Message-ID: <4C80F131.2020004@euromail.se> (raw)
In-Reply-To: <6753EB6004AFF34FAA275742C104F952022BB10D@wacom-nt10.wacom.com>
On 09/03/2010 02:47 PM, Ping Cheng wrote:
[...]
> + /* quirks for bamboo touch */
> + if (features->x_max == 480 && features->y_max == 320) {
>
> A check on all Bamboo touch devices can be a generic way to cover all
> Bamboos with touch feature (4 models). This check can be based on the
> product id or features->type (== BAMBOO_PT) in combination with the
> actual type (pen/touch) of the device. All Bamboo touch devices use the
> same protocol.
I guess the only one who knows if there will be other resolutions reported for
BAMBOO_PT is you. :-) I wanted to not break any eventual resolution improvements
in the BAMBOO_PT family, but if you say there aren't any, using the BAMBOO_PT
check will be better, as you say.
> + features->x_max = 15360;
> + features->y_max = 10240;
>
> I guess these two numbers rely on the original maxes: (480, 320). If so,
> can we also make them generic by accessing features->x_max/y_max
> directly?
If you mean something like "features->x_max <<= 5", absolutely. Again, this all
depends on what resolutions are to be anticipated, and which ones should be
scaled this way.
Henrik
prev parent reply other threads:[~2010-09-03 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 12:17 [PATCH 0/5] input: wacom: Initial support for Bamboo (rev2) Henrik Rydberg
2010-09-03 12:17 ` [PATCH 1/5] input: wacom: Add fuzz parameters to features Henrik Rydberg
2010-09-03 12:17 ` [PATCH 2/5] input: wacom: Parse the Bamboo device family Henrik Rydberg
2010-09-03 12:17 ` [PATCH 3/5] input: wacom: Add support for the Bamboo Touch trackpad (rev3) Henrik Rydberg
2010-09-03 13:01 ` Ping Cheng
2010-09-03 13:06 ` Henrik Rydberg
2010-09-03 15:30 ` Ping Cheng
2010-09-03 16:26 ` Dmitry Torokhov
2010-09-03 18:24 ` Diego Calleja
2010-09-03 12:17 ` [PATCH 4/5] input: wacom: Collect device quirks into single function Henrik Rydberg
2010-09-03 12:17 ` [PATCH 5/5] input: wacom: Add a quirk for lowres Bamboo devices Henrik Rydberg
2010-09-03 12:47 ` Ping Cheng
2010-09-03 12:59 ` Henrik Rydberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C80F131.2020004@euromail.se \
--to=rydberg@euromail.se \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pingc@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).