From: Rafi Rubin <rafi@seas.upenn.edu>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
micki@n-trig.com, rydberg@euromail.se, chatty@enac.fr
Subject: Re: [PATCH] identify firmware version
Date: Wed, 08 Sep 2010 11:42:36 -0400 [thread overview]
Message-ID: <4C87AEEC.3000309@seas.upenn.edu> (raw)
In-Reply-To: <alpine.LNX.2.00.1009081147070.26813@pobox.suse.cz>
On 09/08/10 05:47, Jiri Kosina wrote:
> On Tue, 7 Sep 2010, Jiri Slaby wrote:
>
>>>>>> +
>>>>>> + ret = ntrig_version_string(&data[2], buf);
>>>>>> +
>>>>>> + dev_info(&hdev->dev,
>>>>>> + "Firmware version: %s (%02x%02x %02x%02x)\n",
>>>>>> + buf, data[2], data[3], data[4], data[5]);
>>>>>> +
>>>>>> + kfree(buff);
>>>>
>>>> In any case, this doesn't compile...
>>>>
>>>>>> + }
>>>
>>> Jiri, I moved the code to a separate function as Dmitry suggested, and compiled a kernel from a clean tree using
>>> gcc-3.4 (I think).
>>
>> This version is OK. In the previous one, there was
>> char *buf;
>> ...
>> kfree(buff);
>
> Dmitry, Jiri, thanks a lot for taking care reviewing the patch while I
> have been lagging behind.
>
> Now applied, thanks Rafi.
Thanks Jiri, and thanks for all the feedback.
prev parent reply other threads:[~2010-09-08 15:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 4:54 hid-ntrig documentation and firmware id Rafi Rubin
2010-08-26 4:54 ` [PATCH 1/4] Adding documention Rafi Rubin
2010-08-27 12:06 ` Henrik Rydberg
2010-08-29 19:52 ` Rafi Rubin
2010-08-30 13:25 ` Jiri Kosina
2010-08-26 4:54 ` [PATCH 2/4] a bit of whitespace cleanup Rafi Rubin
2010-08-26 4:54 ` [PATCH 3/4] identify firmware version Rafi Rubin
2010-08-27 12:01 ` Henrik Rydberg
2010-08-29 19:55 ` Rafi Rubin
2010-08-26 4:54 ` [PATCH 4/4] firmware sysfs node Rafi Rubin
2010-08-27 12:09 ` Henrik Rydberg
2010-08-27 16:34 ` Dmitry Torokhov
2010-08-31 2:06 ` Rafi Rubin
2010-09-01 2:06 ` Dmitry Torokhov
2010-09-01 9:48 ` [PATCH] identify firmware version Rafi Rubin
2010-09-01 10:04 ` Rafi Rubin
2010-09-01 12:27 ` Henrik Rydberg
2010-09-01 20:12 ` Jiri Slaby
2010-09-02 0:12 ` Rafi Rubin
2010-09-02 8:03 ` Jiri Slaby
2010-09-02 18:00 ` Rafi Rubin
2010-09-02 18:11 ` Rafi Rubin
2010-09-06 16:42 ` Rafi Rubin
2010-09-06 19:48 ` Dmitry Torokhov
2010-09-06 21:22 ` Jiri Slaby
2010-09-06 23:32 ` Rafi Rubin
2010-09-06 23:36 ` Dmitry Torokhov
2010-09-07 6:54 ` Jiri Slaby
2010-09-08 9:47 ` Jiri Kosina
2010-09-08 15:42 ` Rafi Rubin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C87AEEC.3000309@seas.upenn.edu \
--to=rafi@seas.upenn.edu \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micki@n-trig.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).