Re: [PATCH 4/6] Input: winbond-cir - switch to using new keycode interface

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 08-09-2010 20:09, David Härdeman escreveu:
> On Wed, Sep 08, 2010 at 04:00:04PM -0700, Dmitry Torokhov wrote:
>> On Wed, Sep 08, 2010 at 11:16:17PM +0200, David Härdeman wrote:
>>> On Wed, Sep 08, 2010 at 12:42:00AM -0700, Dmitry Torokhov wrote:
>>>> Switch the code to use new style of getkeycode and setkeycode
>>>> methods to allow retrieving and setting keycodes not only by
>>>> their scancodes but also by index.
>>>>
>>>> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
>>>> ---
>>>>
>>>>  drivers/input/misc/winbond-cir.c |  248 +++++++++++++++++++++++++-------------
>>>>  1 files changed, 163 insertions(+), 85 deletions(-)
>>>
>>> Thanks for doing the conversion for me, but I think you can skip this 
>>> patch. The driver will (if I understood your patchset correctly) still 
>>> work with the old get/setkeycode ioctls and I have a patch lined up that 
>>> converts winbond-cir.c to use ir-core which means all of the input 
>>> related code is removed.
>>>
>>
>> Yes, it should still work with old get/setkeycode. What are the plans
>> for your patch? .37 or later?
> 
> Up to Mauro but I believe it's .37 (sometime after your input patches 
> land).

.37 seems feasible, if you submit your patch in time for review.

Maybe I should create a temporary staging tree for .37 with the input patches
applied there, to allow people to better review and test the rc patches with
everything applied.

Cheers,
Mauro.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html