From: Jonathan Cameron <kernel@jic23.retrosnub.co.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hemanth V <hemanthv@ti.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH V3 1/2] input: CMA3000 Accelerometer driver
Date: Tue, 14 Sep 2010 14:10:01 +0100 [thread overview]
Message-ID: <4C8F7429.1080105@jic23.retrosnub.co.uk> (raw)
In-Reply-To: <20100914080003.GD15167@core.coreip.homeip.net>
On 09/14/10 09:00, Dmitry Torokhov wrote:
> On Wed, Sep 08, 2010 at 12:37:40PM +0100, Jonathan Cameron wrote:
>>
>> I'm happy to see your driver go in as it is currently, what bothers me is that we will end
>> up with incompatible interfaces for all the accelerometers Dmitry takes!
>>
>
> This is a valid concern. How about I chicken out and will not merge any
> new sysfs knobs until you guys decide on reasonable interface? Most set
> up is done by board code anyways, sysfs is more of nice-to-have?
Hemanth, would removing the sysfs hooks from this driver be ok with you?
I'd personally have favoured a merge, add new interfaces when agreed and
deprecate old ones approach, but it is Dmitry's call. Perhaps it is better
to get the majority of the device functionality in place now and add
the bells and whistles later.
For input device things are probably mostly fixed for a particular board
design. There are definitely interesting things one can do if the knobs
are available but they (I think) mostly fall outside of using the device
for input!
Jonathan
next prev parent reply other threads:[~2010-09-14 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 6:17 [PATCH V3 1/2] input: CMA3000 Accelerometer driver Hemanth V
2010-09-08 11:37 ` Jonathan Cameron
2010-09-14 8:00 ` Dmitry Torokhov
2010-09-14 13:10 ` Jonathan Cameron [this message]
2010-09-21 5:46 ` Hemanth V
2010-09-21 10:27 ` Jonathan Cameron
2010-09-08 14:24 ` Murphy, Dan
2010-11-10 14:39 ` Hemanth V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8F7429.1080105@jic23.retrosnub.co.uk \
--to=kernel@jic23.retrosnub.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=hemanthv@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox