linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Trilok Soni <tsoni@codeaurora.org>
To: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
	Kwangwoo LEE <kwangwoo.lee@stericsson.com>,
	Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH v5 1/2] input: add support for Nomadik SKE keypad controller
Date: Wed, 15 Sep 2010 13:03:14 +0530	[thread overview]
Message-ID: <4C9076BA.80106@codeaurora.org> (raw)
In-Reply-To: <1284535498-9954-1-git-send-email-sundar.iyer@stericsson.com>

Hi Sundar,

On 9/15/2010 12:54 PM, Sundar Iyer wrote:
> Add support for the keypad controller in the Scroll Key Encoder (SKE)
> module on the Nomadik family and the DB8500 SoC.
> 
> Acked-by: Linus Walleij <linus.walleij@stericsson.com>
> Signed-off-by: Sundar Iyer <sundar.iyer@stericsson.com>
> ---
> Thanx a bunch to Dmitry for being such a nice and persistent help :)
> 
> v4:
>  - IRQ handler is no longer threaded
>  - incorporated Dmitry's comments to make sure multikey is working
>  - assorted comments from Trilok
>  - pin configuration mistake pointed out thanx to Kwangwoo LEE

Looks good to me. Thanks.

Acked-by: Trilok Soni <tsoni@codeaurora.org>

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2010-09-15  7:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-15  7:24 [PATCH v5 1/2] input: add support for Nomadik SKE keypad controller Sundar Iyer
2010-09-15  7:33 ` Trilok Soni [this message]
2010-09-15  7:52   ` Dmitry Torokhov
2010-09-15  8:57     ` Trilok Soni
2010-09-15  7:55 ` Dmitry Torokhov
2010-09-15  8:49   ` Sundar R IYER
2010-09-15  9:00     ` Dmitry Torokhov
2010-09-15  9:02       ` Sundar R IYER

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9076BA.80106@codeaurora.org \
    --to=tsoni@codeaurora.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kwangwoo.lee@stericsson.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-input@vger.kernel.org \
    --cc=sundar.iyer@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).