From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH 4/4] Input: ads7846 - modificatons of _stop()/_disable() conditions Date: Fri, 17 Sep 2010 17:20:14 +0800 Message-ID: <4C9332CE.6040905@gmail.com> References: <1284634286-8871-1-git-send-email-jason77.wang@gmail.com> <1284634286-8871-4-git-send-email-jason77.wang@gmail.com> <1284634286-8871-5-git-send-email-jason77.wang@gmail.com> <201009162339.06395.dmitry.torokhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.windriver.com ([147.11.1.11]:51085 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967Ab0IQJQk (ORCPT ); Fri, 17 Sep 2010 05:16:40 -0400 In-Reply-To: <201009162339.06395.dmitry.torokhov@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Jason Wang , notasas@gmail.com, vapier@gentoo.org, linux-input@vger.kernel.org Dmitry Torokhov wrote: > Hi Jason, > > On Thursday, September 16, 2010 03:51:26 am Jason Wang wrote: > >> The design like that, we can stop or disable ADC, one difference is >> the disable not only stop the ADC but also close the power regulator. >> So we change the condition flag to stopped in the _stop() function. >> >> Because we call __ads7846_disable() in the suspend/resume process, so >> move disabled flag modification from ads7846_disable() to the >> __ads7846_disable(), otherwise when we call _disable() in the suspend, >> and the ADC is really suspended but the flag shows that it isn't. >> > > I disagree with the patch. "Disable" knob is separate from PM knobs > (suspend/resume); and thus that attribute should only read "1" when > user forcibly disabled the device via sysfs. Same goes for open/close. > > Thanks. > > OK, i will fix this patch. Thanks, Jason.