From: Henrik Rydberg <rydberg@euromail.se>
To: Naveen Kumar G <naveen.gaddipati@stericsson.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
STEricsson_nomadik_linux@list.st.com,
linux-input@vger.kernel.org, tsoni@codeaurora.org
Subject: Re: [PATCHv5] input: ROHM BU21013 touch panel controller support
Date: Sat, 02 Oct 2010 09:25:41 +0200 [thread overview]
Message-ID: <4CA6DE75.8010508@euromail.se> (raw)
In-Reply-To: <1285930790-2206-1-git-send-email-naveen.gaddipati@stericsson.com>
On 10/01/2010 12:59 PM, Naveen Kumar G wrote:
[...]
> +static int bu21013_do_touch_report(struct bu21013_ts_data *data)
> +{
> + u8 buf[LENGTH_OF_BUFFER];
> + unsigned int pos_x[2], pos_y[2];
> + bool has_x_sensors, has_y_sensors;
> + int finger_down_count = 0;
> + int i;
> +
> + if (data == NULL)
> + return -EINVAL;
> +
> + if (bu21013_read_block_data(data, buf) < 0)
> + return -EINVAL;
> +
> + has_x_sensors = hweight32(buf[0] & BU21013_SENSORS_EN_0_7);
> + has_y_sensors = hweight32(((buf[1] & BU21013_SENSORS_EN_8_15) |
> + ((buf[2] & BU21013_SENSORS_EN_16_23) << SHIFT_8)) >> SHIFT_2);
> + if (!has_x_sensors || !has_y_sensors)
> + return 0;
I believe this line will lead to fingers stuck in the down position.
Henrik
next prev parent reply other threads:[~2010-10-02 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 10:59 [PATCHv5] input: ROHM BU21013 touch panel controller support Naveen Kumar G
2010-10-01 11:19 ` Datta, Shubhrajyoti
2010-10-02 6:24 ` Henrik Rydberg
2010-10-04 5:15 ` Naveen Kumar GADDIPATI
2010-10-04 6:33 ` Henrik Rydberg
2010-10-02 7:25 ` Henrik Rydberg [this message]
2010-10-04 4:52 ` Naveen Kumar GADDIPATI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA6DE75.8010508@euromail.se \
--to=rydberg@euromail.se \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=naveen.gaddipati@stericsson.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).