Re: [PATCH 4/4] Input: ads7846 - modificatons of _stop()/_disable() conditions

[Jason Wang <jason77.wang@gmail.com>]

Hi Dmitry,

I have validated the new patch based off the 2.6.36-rc7 on
the ti_omap3530evm, it works fine.

Thanks,
Jason.

Dmitry Torokhov wrote:
> Hi Jason.
>
> On Tue, Oct 12, 2010 at 05:58:36PM +0800, Jason Wang wrote:
>   
>> Hi Dmitry,
>>
>> Still remember the thread irq modificition for the ads7846.c? I sent
>> 4 patches,
>> you pointed out that the last patch(the 4th one) seems not right, i think it
>> over and find i was wrong because i mingled two independent flags(
>> disabled/suspended). Then i gave my understanding and two plans to
>> be chosen 3 weeks ago, but by now don't get feedback.
>>     
>
> Sorry about that.
>
>   
>> @@ -253,9 +253,10 @@ static void ads7846_enable(struct ads7846 *ts)
>> {
>> mutex_lock(&ts->lock);
>>
>> - if (ts->disabled && !ts->suspended)
>> + if (ts->disabled && !ts->suspended) {
>> + ts->disabled = false;
>> __ads7846_enable(ts);
>>     
>
> If the device was both disabled and suspended then enable will never
> succeed.
>
> I actually was looking over the patches yesterday and I believe I
> corrected the problem you mentioned. I rolled all patches together (no
> reason to keep them separate - they have not been yet applied to
> non-rebasing branch and they are simple fix-ups to the issues introduced
> by the fisrt patch). Could you please try the patch below and if it
> still works I'll queue for .37.
>
> Thanks!
>
>