From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Eremin-Solenikov Subject: Re: [PATCH v3] serio: add support for PS2Mult multiplexer protocol Date: Mon, 18 Oct 2010 15:24:51 +0400 Message-ID: <4CBC2E83.70308@gmail.com> References: <1285260285-660-1-git-send-email-dbaryshkov@gmail.com> <20100930062547.GF5260@core.coreip.homeip.net> <20101007163606.GA24406@core.coreip.homeip.net> <20101014142347.GA18011@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:46453 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754698Ab0JRLZO (ORCPT ); Mon, 18 Oct 2010 07:25:14 -0400 Received: by wwd20 with SMTP id 20so33722wwd.1 for ; Mon, 18 Oct 2010 04:25:13 -0700 (PDT) In-Reply-To: <20101014142347.GA18011@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org Hello, On 14.10.2010 18:23, Dmitry Torokhov wrote: > On Fri, Oct 08, 2010 at 12:50:34PM +0400, Dmitry Eremin-Solenikov wrote: >> Hello, >> >> On Thu, Oct 7, 2010 at 8:36 PM, Dmitry Torokhov >> wrote: >>> On Thu, Oct 07, 2010 at 07:19:57PM +0400, Dmitry Eremin-Solenikov wrote: >>>> Hello, >>>> >>>> On Thu, Sep 30, 2010 at 10:25 AM, Dmitry Torokhov >>>> wrote: >>>>> On Wed, Sep 29, 2010 at 04:45:53PM +0400, Dmitry Eremin-Solenikov wrote: >>>>>> On Thu, Sep 23, 2010 at 8:44 PM, Dmitry Eremin-Solenikov >>>>>> wrote: >>>>>>> PS2Mult is a simple serial protocol used for multiplexing several PS/2 streams >>>>>>> into one serial data stream. It's used e.g. on TQM85xx serie of boards. >>>>>>> >>>>>>> Signed-off-by: Dmitry Eremin-Solenikov >>>>>>> --- >>>>>>> >>>>>>> It actually depends on "serio: multiple children" patch. I'm not resending it >>>>>>> as you were the originator of the latest version of the patch. >>>>>> >>>>>> So, what about this version of patch? >>>>>> >>>>> >>>>> Looks better but I think you also need ->start() to make sure you do not >>>>> try to deliver events too early. Does the following still work for you? >>>> >>>> Sorry for the delay. Crashes w/o the attached patch. >>>> >>> >>> Ah, I see, however what I actually wanted is to create ports before hand >>> and handle any errors that might arise and then enable the device and >>> register child ports. >>> >>> If you apply the patch below instead of yours does it still work? >> >> It won't work, as we don't set psm->ports[i].serio before ps2mult_serio_start() >> > > Indeed. I guess we need to set the pointer immediately then and also add > a flag to the port structure telling whether it has been registered. > Does the following work for you by any chance? Yeah, works w/o any glitches. Thank you. -- With best wishes Dmitry