From: Gabor Juhos <juhosg@openwrt.org>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Kevin Hilman <khilman@deeprootsystems.com>,
"Nori, Sekhar" <nsekhar@ti.com>
Subject: Re: [PATCH WIP 0/6] suggested changes to gpio_buttons driver
Date: Tue, 30 Nov 2010 19:26:53 +0100 [thread overview]
Message-ID: <4CF541ED.80905@openwrt.org> (raw)
In-Reply-To: <AANLkTikv6CV-z1pkvwvRd+ahv3AvKzXVB0XivNT6G2XB@mail.gmail.com>
Hi Ben, Dmitry,
>> <...>
>> It works for me, however I have additional fixes on top of Ben's changes. I will
>> post an updated version soon.
>
> This "polled gpio keys" driver was your invention. FWIW, I think your
> upcoming updated version should be given consideration before
> proceeding with the collection of patches discussed above.
>
>> The original driver was a part of a patch-set which adds support for a new MIPS
>> platform. There are a couple of patches in that series which requires this one.
>> It would be nice if the driver would be able to go through the MIPS tree to
>> avoid cross-tree dependencies.
>
> Since the da850-evm series which depends on this patch is proposed for
> the linux-davinci tree I think that to avoid cross-tree dependencies
> they would all need to be taken in one tree. That is, unless there is
> zero chance of the da850-evm series being taken-up for 2.6.38 along
> with this driver. I have added Kevin Hilman, the linux-davinci
> maintainer, and Sekhar Nori, the da850-evm maintainer, to the CC of
> this email so that they can participate in the discussion of when and
> how the patches should be merged.
>
> Kevin, Sekhar, do you think that "da850-evm: add gpio-{keys,leds} for
> UI and BB expanders" could be queued for 2.6.38?
Well, I had to rethink that a bit. In my original patch-set I have several
patches which must be acked by other subsystem maintainers.
Given the possibility that my patch-set will not be merged for 2.6.38 I will
drop the driver from that set so the driver can go through any tree.
Additionally I will post my changes in a follow up e-mail. Those changes goes on
top of Dmitry's changes, so the whole stuff can be folded into the original patch.
Regards,
Gabor
next prev parent reply other threads:[~2010-11-30 18:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1290524800-21419-1-git-send-email-juhosg@openwrt.org>
2010-11-23 15:06 ` [PATCH 09/18] input: add input driver for polled GPIO buttons Gabor Juhos
2010-11-23 19:24 ` Ben Gardiner
2010-11-24 17:24 ` Ben Gardiner
2010-11-24 18:54 ` Gabor Juhos
2010-11-24 20:28 ` Ben Gardiner
2010-11-24 21:01 ` [PATCH WIP 0/6] suggested changes to gpio_buttons driver Ben Gardiner
2010-11-24 21:01 ` [PATCH WIP 1/6] fixup gpio_buttons: use the same debounce_interval member found in gpio_key to obtain a threshold count based on polling interval Ben Gardiner
2010-11-24 21:01 ` [PATCH WIP 2/6] fixup gpio_buttons: use existing gpio_keys_button structure instead of introducing new gpio_button structure Ben Gardiner
2010-11-24 21:01 ` [PATCH WIP 3/6] fixup gpio_buttons: detect and error-out if a button is requested for wakeup Ben Gardiner
2010-11-24 21:01 ` [PATCH WIP 4/6] fixup gpio_buttons: show units of poll_interval platform data member Ben Gardiner
2010-11-24 21:01 ` [PATCH WIP 5/6] fixup gpio_buttons: move gpio_buttons.c to drivers/input/keyboard from drivers/input/misc Ben Gardiner
2010-11-24 21:01 ` [PATCH WIP 6/6] fixup gpio_buttons : rename gpio-buttons / gpio_buttons to gpio-keys-polled / gpio_keys_polled Ben Gardiner
2010-11-30 7:56 ` [PATCH WIP 0/6] suggested changes to gpio_buttons driver Dmitry Torokhov
2010-11-30 10:30 ` Gabor Juhos
2010-11-30 14:29 ` Ben Gardiner
2010-11-30 18:26 ` Gabor Juhos [this message]
2010-11-30 18:44 ` [PATCH 0/8] input: gpio_keys_polled fixes Gabor Juhos
2010-11-30 22:16 ` Ben Gardiner
2010-12-05 9:11 ` Gabor Juhos
2010-12-09 0:06 ` Dmitry Torokhov
2010-12-09 8:07 ` Gabor Juhos
2010-12-09 21:36 ` Ben Gardiner
2010-11-30 18:44 ` [PATCH 1/8] input: gpio_keys_polled: add MODULE_ALIAS Gabor Juhos
2010-11-30 18:44 ` [PATCH 2/8] input: gpio_keys_polled: return -EINVAL if wakeup specified Gabor Juhos
2010-11-30 18:44 ` [PATCH 3/8] input: gpio_keys_polled: avoid possible division by zero Gabor Juhos
2010-11-30 18:44 ` [PATCH 4/8] input: gpio_keys_polled: use DIV_ROUND_UP to compute the threshold value Gabor Juhos
2010-11-30 18:44 ` [PATCH 5/8] input: gpio_keys_polled: precompute threshold value in the probe routine Gabor Juhos
2010-11-30 18:44 ` [PATCH 6/8] input: gpio_keys_polled: use tabs instead of spaces for indentation Gabor Juhos
2010-11-30 18:44 ` [PATCH 7/8] input: gpio_keys_polled: remove a local variable Gabor Juhos
2010-11-30 18:44 ` [PATCH 8/8] input: gpio_keys_polled: fix Kconfig help text Gabor Juhos
2010-12-01 22:53 ` Ferenc Wagner
2010-12-05 9:11 ` Gabor Juhos
2010-12-05 9:34 ` [PATCH v2 " Gabor Juhos
2010-11-28 8:31 ` [PATCH 09/18] input: add input driver for polled GPIO buttons Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF541ED.80905@openwrt.org \
--to=juhosg@openwrt.org \
--cc=bengardiner@nanometrics.ca \
--cc=dmitry.torokhov@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-input@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).