linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@euromail.se>
To: Ping Cheng <pinglinux@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Ping Cheng <pingc@wacom.com>,
	Chris Bagwell <chris@cnpbagwell.com>,
	Peter Hutterer <peter.hutterer@who-t.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] input: mt: Move tracking and pointer emulation to input-mt
Date: Tue, 07 Dec 2010 21:58:30 +0100	[thread overview]
Message-ID: <4CFE9FF6.2080800@euromail.se> (raw)
In-Reply-To: <AANLkTik=A5xc2RexWqDMvumFqbA6HtzynWmP=Fz6+SvE@mail.gmail.com>

>

> Acked-by: Ping Cheng <pingc@wacom.com>


Thanks.


> I do see an issue when pen coming in prox while fingers were on the
> tablet. Fingers up events are missing.

>
> Since it is unrelated to this patch, I'll submit another patch as a
> bug fix later.

Actually, I believe it is correct as is. One could always argue (and I did at
the time of that change) whether touch up is the right thing to do in the
proximity of the pen, but that is what the code does now. As proof, check how
input_mt_report_slot_state() is used.

Cheers,
Henrik

  reply	other threads:[~2010-12-07 20:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 11:45 [PATCH v3] input: mt: Move tracking and pointer emulation to input-mt Henrik Rydberg
2010-12-07 14:53 ` Jiri Kosina
2010-12-07 20:04   ` Henrik Rydberg
2010-12-07 20:39     ` Ping Cheng
2010-12-07 20:58       ` Henrik Rydberg [this message]
2010-12-07 21:17         ` Ping Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CFE9FF6.2080800@euromail.se \
    --to=rydberg@euromail.se \
    --cc=chris@cnpbagwell.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=pingc@wacom.com \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).