From: Henrik Rydberg <rydberg@euromail.se>
To: Valdis.Kletnieks@vt.edu
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Ping Cheng <pingc@wacom.com>,
Chris Bagwell <chris@cnpbagwell.com>
Subject: Re: [RFC][PATCH] input: Introduce device information ioctl
Date: Wed, 08 Dec 2010 21:37:05 +0100 [thread overview]
Message-ID: <4CFFEC71.8060103@euromail.se> (raw)
In-Reply-To: <25336.1291839964@localhost>
>
>> /*
>> + * Device types
>> + */
>> +
>> +#define DEVTYPE_KEYBOARD 0
>> +#define DEVTYPE_MOUSE 1
>> +#define DEVTYPE_JOYSTICK 2
>> +#define DEVTYPE_TOUCHPAD 3
>> +#define DEVTYPE_TABLET 4
>> +#define DEVTYPE_TOUCHSCREEN 5
>
> Add a #define DEVTYPE_UNKNOWN 0 and push everybody else down one. That way,
> an uninitialized 'struct input_devinfo' won't claim to be a keyboard.
Since types is a bitmask, the initial value will actually be unclaimed already.
To be explicit, for a keyboard, types = 1 << 0 = 1.
Thanks,
Henrik
prev parent reply other threads:[~2010-12-08 20:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 7:25 [RFC][PATCH] input: Introduce device information ioctl Henrik Rydberg
2010-12-07 9:16 ` Dmitry Torokhov
2010-12-07 10:48 ` Kay Sievers
2010-12-07 10:56 ` Dmitry Torokhov
2010-12-07 11:19 ` Kay Sievers
2010-12-07 12:44 ` Arnd Bergmann
2010-12-07 12:52 ` Kay Sievers
2010-12-07 12:55 ` Arnd Bergmann
2010-12-07 12:40 ` Arnd Bergmann
2010-12-07 12:49 ` Kay Sievers
2010-12-07 16:51 ` Dmitry Torokhov
2010-12-07 19:57 ` Henrik Rydberg
2010-12-08 6:02 ` Dmitry Torokhov
2010-12-08 19:04 ` Henrik Rydberg
2010-12-09 9:25 ` Dmitry Torokhov
2010-12-07 16:22 ` Greg KH
2010-12-07 16:48 ` Dmitry Torokhov
2010-12-07 18:48 ` Ping Cheng
2010-12-07 19:35 ` Dmitry Torokhov
2010-12-07 19:18 ` Chris Bagwell
2010-12-07 19:37 ` Dmitry Torokhov
2010-12-08 20:26 ` Valdis.Kletnieks
2010-12-08 20:37 ` Henrik Rydberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFFEC71.8060103@euromail.se \
--to=rydberg@euromail.se \
--cc=Valdis.Kletnieks@vt.edu \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pingc@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).