From: Henrik Rydberg <rydberg@euromail.se>
To: Chase Douglas <chase.douglas@canonical.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Takashi Iwai <tiwai@suse.de>,
Chris Bagwell <chris@cnpbagwell.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: synaptics - add multitouch packet support
Date: Tue, 14 Dec 2010 00:15:24 +0100 [thread overview]
Message-ID: <4D06A90C.90009@euromail.se> (raw)
In-Reply-To: <4D06A7B1.6060609@canonical.com>
On 12/14/2010 12:09 AM, Chase Douglas wrote:
> On 12/13/2010 02:55 PM, Henrik Rydberg wrote:
>> @@ -638,7 +677,7 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv)
>> __set_bit(BTN_LEFT, dev->keybit);
>> __set_bit(BTN_RIGHT, dev->keybit);
>>
>> - if (SYN_CAP_MULTIFINGER(priv->capabilities)) {
>> + if (SYN_CAP_MULTIFINGER(priv->capabilities) | priv->multitouch) {
>
> ^^ Although I think this is functionally correct, it is nevertheless a
> typo. Note that there's only one '|' where there should be two.
Ah, this one was removed but kept popping back in subsequent versions. Will fix,
but not resending now.
Thanks,
Henrik
next prev parent reply other threads:[~2010-12-13 23:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 22:55 [PATCH 1/2] Input: synaptics - add multitouch packet support Henrik Rydberg
2010-12-13 22:55 ` [PATCH 2/2] Input: synaptics - emit multitouch data Henrik Rydberg
2010-12-13 23:14 ` Chase Douglas
2010-12-13 23:09 ` [PATCH 1/2] Input: synaptics - add multitouch packet support Chase Douglas
2010-12-13 23:15 ` Henrik Rydberg [this message]
2010-12-14 21:37 ` Chase Douglas
2010-12-15 14:21 ` Henrik Rydberg
2010-12-15 17:47 ` Chase Douglas
2010-12-15 19:14 ` Chris Bagwell
2010-12-15 21:24 ` Chase Douglas
2010-12-15 23:42 ` Peter Hutterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D06A90C.90009@euromail.se \
--to=rydberg@euromail.se \
--cc=chase.douglas@canonical.com \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).