From: Chase Douglas <chase.douglas@canonical.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Takashi Iwai <tiwai@suse.de>,
Chris Bagwell <chris@cnpbagwell.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Input: synaptics - add multi-finger and semi-mt support
Date: Tue, 21 Dec 2010 12:32:38 -0500 [thread overview]
Message-ID: <4D10E4B6.8070003@canonical.com> (raw)
In-Reply-To: <20101221165956.GA28702@polaris.bitmath.org>
On 12/21/2010 11:59 AM, Henrik Rydberg wrote:
>>> Reported-by: Tobyn Bertram
>>> Not-yet-signed-off-by: Takashi Iwai <tiwai@suse.de>
>>> Not-yet-signed-off-by: Chase Douglas <chase.douglas@canonical.com>
>>> Not-yet-signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
>>> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
>>
>> You can keep my SOB.
>
> Great, thanks.
>
>>> +static void set_slot(struct input_dev *dev, int slot, bool active, int x, int y)
>>> +{
>>> + input_mt_slot(dev, slot);
>>> + input_mt_report_slot_state(dev, MT_TOOL_FINGER, active);
>>> + if (active) {
>>> + input_report_abs(dev, ABS_MT_POSITION_X, x);
>>> + input_report_abs(dev, ABS_MT_POSITION_Y,
>>> + YMAX_NOMINAL + YMIN_NOMINAL - y);
>>> + }
>>> +}
>>
>> I take it that you feel MT_TOOL_FINGER should always be set, even if
>> it's always the same as BTN_TOOL_*? I just want to be sure this is
>> intended so we document it appropriately.
>
> Yes - the MT_TOOLs are only emitted when explicitly set in absbit, but
> the internal interface always handles it. This is actually documented
> in the code (and DocBook).
Ahh, I had forgotten about this.
>>> @@ -623,6 +686,7 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv)
>>> int i;
>>>
>>> __set_bit(INPUT_PROP_POINTER, dev->propbit);
>>> + __set_bit(INPUT_PROP_SEMI_MT, dev->propbit);
>>
>> Shouldn't this only be set when SYN_CAP_ADV_GESTURE(priv->ext_cap_0c) is
>> true?
>
> Indeed - thanks.
All looks good to me with this change :). Thanks again!
-- Chase
next prev parent reply other threads:[~2010-12-21 17:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 13:39 [PATCH v2 0/3] Input: synaptics - add semi-mt support Henrik Rydberg
2010-12-20 13:39 ` [PATCH 1/3] Input: synaptics - report clickpad property Henrik Rydberg
2010-12-21 16:37 ` Chase Douglas
2010-12-20 13:39 ` [PATCH 2/3] Input: synaptics - add multi-finger and semi-mt support Henrik Rydberg
2010-12-20 16:20 ` Chris Bagwell
2010-12-21 16:35 ` Chase Douglas
2010-12-21 16:59 ` Henrik Rydberg
2010-12-21 17:32 ` Chase Douglas [this message]
2010-12-21 18:06 ` Chris Bagwell
2010-12-21 18:36 ` Henrik Rydberg
2010-12-20 13:39 ` [PATCH 3/3] Input: synaptics - ignore bogus mt packet Henrik Rydberg
2010-12-21 16:40 ` Chase Douglas
2010-12-22 10:12 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D10E4B6.8070003@canonical.com \
--to=chase.douglas@canonical.com \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).