linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srikar <ext-srikar.1.bhavanarayana@nokia.com>
To: ext Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, lauri.leukkunen@nokia.com,
	aaro.koskinen@nokia.com, kwlee@mtekvision.com,
	ext-phil.2.carmody@nokia.com,
	David Brownell <dbrownell@users.sourceforge.net>,
	Imre Deak <imre.deak@nokia.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	Ari Kauppi <Ext-Ari.Kauppi@nokia.com>,
	Tony Lindgren <tony@atomide.com>,
	Jarkko Nikula <jhnikula@gmail.com>,
	Eero Nurkkala <ext-eero.nurkkala@nokia.com>,
	Roman Tereshonkov <roman.tereshonkov@nokia.com>
Subject: Re: [PATCH 1/4] input: touchscreen: introduce tsc2005 driver
Date: Wed, 22 Dec 2010 10:42:07 +0200	[thread overview]
Message-ID: <4D11B9DF.4050107@nokia.com> (raw)
In-Reply-To: <20101216075716.GD26567@core.coreip.homeip.net>

Hi Torkhov ,
           Other differences between tsc2005 and tsc2007 driver are
request_threaded_irq is being used by tsc2005 and request_irq is being
used by tsc2007.
        Similar  type there are other differences in the both code where
tsc200x core need to implemented  other then bus access methods,need to
discuss with tsc2007 driver to make it common implementation for both
drivers.More over added the kwlee@mtekvision.com who is contributor for
tsc2007 driver which is also need to modified for to tsc200x and
tsc2007.c.To adapt requires comments and discussion with kwlee and Lauri.
Please let me know your comments about this.So that patches to enable
touch screen driver in  platform code can sent to input.
Regards,
Srikar
     

On 12/16/2010 09:57 AM, ext Dmitry Torokhov wrote:
> On Wed, Dec 15, 2010 at 11:39:12AM +0200, Srikar wrote:
>> Hi ToroKhov,
>>               TSC2005 is using SPI interface/driver  and TSC2007 driver
>> is using i2C Interface/driver are main differences.
> I see. In this case I believe that, instead of creating completely
> separate driver, we need to abstract bus access from tsc2007 and convert
> the driver into tsc200x-core.c core piece and tcs2005.c/tsc2007.c
> implementing just bus access methods. Pretty much what was done for
> ad714x, adxl34x, ad7879 and other drivers.
>
>> I have a question, Can I release patch to input for enabling the driver
>> tsc2005 located at *arch/arm/mach-omap2/*
>>
>> As commented below by Tony Lindgren,
>> This does not exist in mainline yet, please send this patch
>> along with the tsc2005 driver via the input list. For this one:
>>
> I am not sure what this means... If you want to submit parts of platform
> code through my tree that should be fine as long as respective
> maintainer of given arch is OK with it as well.
>
> Thanks.
>


  parent reply	other threads:[~2010-12-22  8:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25 15:45 [PATCH 1/4] input: touchscreen: introduce tsc2005 driver Srikar
2010-12-13  8:51 ` Dmitry Torokhov
     [not found]   ` <4D088CC0.9080402@nokia.com>
2010-12-16  7:57     ` Dmitry Torokhov
2010-12-17 17:50       ` Tony Lindgren
2010-12-22  8:42       ` Srikar [this message]
2010-12-22 16:15         ` Phil Carmody
2011-02-14 11:14       ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D11B9DF.4050107@nokia.com \
    --to=ext-srikar.1.bhavanarayana@nokia.com \
    --cc=Ext-Ari.Kauppi@nokia.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=aaro.koskinen@nokia.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ext-eero.nurkkala@nokia.com \
    --cc=ext-phil.2.carmody@nokia.com \
    --cc=imre.deak@nokia.com \
    --cc=jhnikula@gmail.com \
    --cc=kwlee@mtekvision.com \
    --cc=lauri.leukkunen@nokia.com \
    --cc=linux-input@vger.kernel.org \
    --cc=roman.tereshonkov@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).