* [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue [not found] <1294062595-30097-1-git-send-email-tj@kernel.org> @ 2011-01-03 13:49 ` Tejun Heo 2011-01-03 14:39 ` Dan Carpenter 0 siblings, 1 reply; 7+ messages in thread From: Tejun Heo @ 2011-01-03 13:49 UTC (permalink / raw) To: linux-kernel Cc: Tejun Heo, Dmitry Torokhov, linux-input, Dan Carpenter, Todd Fischer With cmwq, there's no reason to use a separate workqueue. Drop tps6507x_ts->wq and use system_wq instead. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org Cc: Dan Carpenter <error27@gmail.com> Cc: Todd Fischer <todd.fischer@ridgerun.com> --- Only compile tested. Please feel free to take it into the subsystem tree or simply ack - I'll route it through the wq tree. Thanks. drivers/input/touchscreen/tps6507x-ts.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c index c8c136c..4303149 100644 --- a/drivers/input/touchscreen/tps6507x-ts.c +++ b/drivers/input/touchscreen/tps6507x-ts.c @@ -43,7 +43,6 @@ struct tps6507x_ts { struct input_dev *input_dev; struct device *dev; char phys[32]; - struct workqueue_struct *wq; struct delayed_work work; unsigned polling; /* polling is active */ struct ts_event tc; @@ -220,8 +219,8 @@ done: poll = 1; if (poll) { - schd = queue_delayed_work(tsc->wq, &tsc->work, - msecs_to_jiffies(tsc->poll_period)); + schd = schedule_delayed_work(&tsc->work, + msecs_to_jiffies(tsc->poll_period)); if (schd) tsc->polling = 1; else { @@ -303,7 +302,6 @@ static int tps6507x_ts_probe(struct platform_device *pdev) tsc->input_dev = input_dev; INIT_DELAYED_WORK(&tsc->work, tps6507x_ts_handler); - tsc->wq = create_workqueue("TPS6507x Touchscreen"); if (init_data) { tsc->poll_period = init_data->poll_period; @@ -325,8 +323,8 @@ static int tps6507x_ts_probe(struct platform_device *pdev) if (error) goto err2; - schd = queue_delayed_work(tsc->wq, &tsc->work, - msecs_to_jiffies(tsc->poll_period)); + schd = schedule_delayed_work(&tsc->work, + msecs_to_jiffies(tsc->poll_period)); if (schd) tsc->polling = 1; @@ -341,7 +339,6 @@ static int tps6507x_ts_probe(struct platform_device *pdev) err2: cancel_delayed_work_sync(&tsc->work); - destroy_workqueue(tsc->wq); input_free_device(input_dev); err1: kfree(tsc); @@ -357,7 +354,6 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev) struct input_dev *input_dev = tsc->input_dev; cancel_delayed_work_sync(&tsc->work); - destroy_workqueue(tsc->wq); input_unregister_device(input_dev); -- 1.7.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue 2011-01-03 13:49 ` [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue Tejun Heo @ 2011-01-03 14:39 ` Dan Carpenter 2011-01-03 16:34 ` Todd Fischer 0 siblings, 1 reply; 7+ messages in thread From: Dan Carpenter @ 2011-01-03 14:39 UTC (permalink / raw) To: Tejun Heo; +Cc: linux-kernel, Dmitry Torokhov, linux-input, Todd Fischer On Mon, Jan 03, 2011 at 02:49:33PM +0100, Tejun Heo wrote: > With cmwq, there's no reason to use a separate workqueue. Drop > tps6507x_ts->wq and use system_wq instead. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: linux-input@vger.kernel.org > Cc: Dan Carpenter <error27@gmail.com> > Cc: Todd Fischer <todd.fischer@ridgerun.com> > --- > Only compile tested. Please feel free to take it into the subsystem > tree or simply ack - I'll route it through the wq tree. > This is that driver that polls every 30 ms. :/ Todd, is there no way to avoid this? What was the status on that? regards, dan carpenter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue 2011-01-03 14:39 ` Dan Carpenter @ 2011-01-03 16:34 ` Todd Fischer 2011-01-25 14:19 ` Tejun Heo 0 siblings, 1 reply; 7+ messages in thread From: Todd Fischer @ 2011-01-03 16:34 UTC (permalink / raw) To: Dan Carpenter, Tejun Heo, linux-kernel, Dmitry Torokhov, linux-input Hi Dan, Polling is only necessary because I was given brain dead hardware. I was expecting updated hardware with the interrupt signal connected properly, but haven't received it yet. Any reasonable hardware will not need tps6507x-ts polling. I was under the impression I could only push patches that I have tested. Since I haven't tested an interrupt version of the driver, I didn't include a patch that removes the polling and replaces it with interrupts. I have another customer planning on using the TPS6507x chip for touch screen. I expect their hardware in around 3 weeks. Todd On 01/03/2011 07:39 AM, Dan Carpenter wrote: > On Mon, Jan 03, 2011 at 02:49:33PM +0100, Tejun Heo wrote: >> With cmwq, there's no reason to use a separate workqueue. Drop >> tps6507x_ts->wq and use system_wq instead. >> >> Signed-off-by: Tejun Heo<tj@kernel.org> >> Cc: Dmitry Torokhov<dmitry.torokhov@gmail.com> >> Cc: linux-input@vger.kernel.org >> Cc: Dan Carpenter<error27@gmail.com> >> Cc: Todd Fischer<todd.fischer@ridgerun.com> >> --- >> Only compile tested. Please feel free to take it into the subsystem >> tree or simply ack - I'll route it through the wq tree. >> > This is that driver that polls every 30 ms. :/ Todd, is there no way > to avoid this? What was the status on that? > > regards, > dan carpenter > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue 2011-01-03 16:34 ` Todd Fischer @ 2011-01-25 14:19 ` Tejun Heo 2011-01-25 16:13 ` Todd Fischer 0 siblings, 1 reply; 7+ messages in thread From: Tejun Heo @ 2011-01-25 14:19 UTC (permalink / raw) To: Todd Fischer; +Cc: Dan Carpenter, linux-kernel, Dmitry Torokhov, linux-input On Mon, Jan 03, 2011 at 09:34:43AM -0700, Todd Fischer wrote: > Hi Dan, > > Polling is only necessary because I was given brain dead hardware. > I was expecting updated hardware with the interrupt signal connected > properly, but haven't received it yet. > > Any reasonable hardware will not need tps6507x-ts polling. I was > under the impression I could only push patches that I have tested. > Since I haven't tested an interrupt version of the driver, I didn't > include a patch that removes the polling and replaces it with > interrupts. > > I have another customer planning on using the TPS6507x chip for > touch screen. I expect their hardware in around 3 weeks. Shall I apply the patch? Thanks. -- tejun ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue 2011-01-25 14:19 ` Tejun Heo @ 2011-01-25 16:13 ` Todd Fischer 2011-01-25 16:50 ` Dmitry Torokhov 0 siblings, 1 reply; 7+ messages in thread From: Todd Fischer @ 2011-01-25 16:13 UTC (permalink / raw) To: Tejun Heo; +Cc: Dan Carpenter, linux-kernel, Dmitry Torokhov, linux-input On 01/25/2011 07:19 AM, Tejun Heo wrote: > Shall I apply the patch? > Thanks Yes, apply the patch. I am not sure of the syntax for attaching my sign off. Hope this is okay. Todd Signed-off-by: Todd Fischer<todd.fischer@ridgerun.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue 2011-01-25 16:13 ` Todd Fischer @ 2011-01-25 16:50 ` Dmitry Torokhov 2011-01-26 10:43 ` Tejun Heo 0 siblings, 1 reply; 7+ messages in thread From: Dmitry Torokhov @ 2011-01-25 16:50 UTC (permalink / raw) To: Todd Fischer; +Cc: Tejun Heo, Dan Carpenter, linux-kernel, linux-input On Tue, Jan 25, 2011 at 09:13:45AM -0700, Todd Fischer wrote: > On 01/25/2011 07:19 AM, Tejun Heo wrote: > >Shall I apply the patch? > >Thanks > Yes, apply the patch. I am not sure of the syntax for attaching my > sign off. Hope this is okay. > > Todd > > Signed-off-by: Todd Fischer<todd.fischer@ridgerun.com> > That should be Acked-by since you are not passing the patch along. Fine with the as well. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue 2011-01-25 16:50 ` Dmitry Torokhov @ 2011-01-26 10:43 ` Tejun Heo 0 siblings, 0 replies; 7+ messages in thread From: Tejun Heo @ 2011-01-26 10:43 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: Todd Fischer, Dan Carpenter, linux-kernel, linux-input On Tue, Jan 25, 2011 at 08:50:06AM -0800, Dmitry Torokhov wrote: > On Tue, Jan 25, 2011 at 09:13:45AM -0700, Todd Fischer wrote: > > On 01/25/2011 07:19 AM, Tejun Heo wrote: > > >Shall I apply the patch? > > >Thanks > > Yes, apply the patch. I am not sure of the syntax for attaching my > > sign off. Hope this is okay. > > > > Todd > > > > Signed-off-by: Todd Fischer<todd.fischer@ridgerun.com> > > > > That should be Acked-by since you are not passing the patch along. Added ack-by's of Todd and you. Thank you. -- tejun ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-01-26 10:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1294062595-30097-1-git-send-email-tj@kernel.org>
2011-01-03 13:49 ` [PATCH 10/32] input/tps6507x-ts: use system_wq instead of dedicated workqueue Tejun Heo
2011-01-03 14:39 ` Dan Carpenter
2011-01-03 16:34 ` Todd Fischer
2011-01-25 14:19 ` Tejun Heo
2011-01-25 16:13 ` Todd Fischer
2011-01-25 16:50 ` Dmitry Torokhov
2011-01-26 10:43 ` Tejun Heo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).