From mboxrd@z Thu Jan  1 00:00:00 1970
From: Trilok Soni <tsoni@codeaurora.org>
Subject: Re: [PATCH v3] input: tegra-kbc - Add tegra keyboard driver
Date: Tue, 11 Jan 2011 12:54:50 +0530
Message-ID: <4D2C05C2.9040705@codeaurora.org>
References: <1294422307-19107-1-git-send-email-riyer@nvidia.com> <4D2B71CB.1060004@codeaurora.org> <1FC56210173BB445BD77F608D6FB8D03165A00805E@HQMAIL03.nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <linux-input-owner@vger.kernel.org>
Received: from wolverine01.qualcomm.com ([199.106.114.254]:11291 "EHLO
	wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751320Ab1AKHZE (ORCPT
	<rfc822;linux-input@vger.kernel.org>);
	Tue, 11 Jan 2011 02:25:04 -0500
In-Reply-To: <1FC56210173BB445BD77F608D6FB8D03165A00805E@HQMAIL03.nvidia.com>
Sender: linux-input-owner@vger.kernel.org
List-Id: linux-input@vger.kernel.org
To: Rakesh Iyer <riyer@nvidia.com>
Cc: "jj@chaosbits.net" <jj@chaosbits.net>, "shubhrajyoti@ti.com" <shubhrajyoti@ti.com>, "ccross@android.com" <ccross@android.com>, "konkers@android.com" <konkers@android.com>, "olof@lixom.net" <olof@lixom.net>, Andrew Chew <AChew@nvidia.com>, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>

Hi Rakesh,

On 1/11/2011 2:41 AM, Rakesh Iyer wrote:
> Thanks for the review.
> 
> A quick response regarding the following comment.
> 
>>
>>> +
>>> +#include <linux/module.h>
>>> +#include <linux/input.h>
>>> +#include <linux/platform_device.h>
>>> +#include <linux/delay.h>
>>> +#include <linux/io.h>
>>> +#include <linux/interrupt.h>
>>> +#include <linux/clk.h>
>>> +#include <linux/slab.h>
>>> +#include <mach/clk.h>
>>
>> You may not need this.
>>
> 
> The mach/clk.h file contains declarations for tegra_periph_reset_assert and tegra_periph_reset_deassert which are needed.

It is really bad if it can't be addressed through clk framework. I will check this, but this
keyboard controller is on-chip so we should be fine I guess.

I hope that these APIs are not required for device drivers which are on external bus like I2C.

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.