* [PATCH] serio: allow registered drivers to get status flag @ 2011-01-18 12:57 David Engraf 2011-01-18 19:57 ` Dmitry Torokhov 0 siblings, 1 reply; 5+ messages in thread From: David Engraf @ 2011-01-18 12:57 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: linux-input, linux-kernel [-- Attachment #1: Type: text/plain, Size: 154 bytes --] Parse the status byte information to the registered serio drivers as well as the character bytes. Signed-off-by: David Engraf <david.engraf@sysgo.com> [-- Attachment #2: serport_parse_flags.diff --] [-- Type: text/x-diff, Size: 886 bytes --] --- linux-2.6.37/drivers/input/serio/serport.c.orig 2011-01-18 12:33:41.421709232 +0100 +++ linux-2.6.37/drivers/input/serio/serport.c 2011-01-18 13:33:24.521711214 +0100 @@ -116,8 +116,8 @@ static void serport_ldisc_close(struct t /* * serport_ldisc_receive() is called by the low level tty driver when characters - * are ready for us. We forward the characters, one by one to the 'interrupt' - * routine. + * are ready for us. We forward the characters and flags, one by one to the + * 'interrupt' routine. */ static void serport_ldisc_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, int count) @@ -132,7 +132,7 @@ static void serport_ldisc_receive(struct goto out; for (i = 0; i < count; i++) - serio_interrupt(serport->serio, cp[i], 0); + serio_interrupt(serport->serio, cp[i], fp[i]); out: spin_unlock_irqrestore(&serport->lock, flags); ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serio: allow registered drivers to get status flag 2011-01-18 12:57 [PATCH] serio: allow registered drivers to get status flag David Engraf @ 2011-01-18 19:57 ` Dmitry Torokhov 2011-01-20 9:05 ` David Engraf 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Torokhov @ 2011-01-18 19:57 UTC (permalink / raw) To: David Engraf; +Cc: linux-input, linux-kernel On Tue, Jan 18, 2011 at 01:57:21PM +0100, David Engraf wrote: > Parse the status byte information to the registered serio drivers as > well as the character bytes. > > Signed-off-by: David Engraf <david.engraf@sysgo.com> > > --- linux-2.6.37/drivers/input/serio/serport.c.orig 2011-01-18 12:33:41.421709232 +0100 > +++ linux-2.6.37/drivers/input/serio/serport.c 2011-01-18 13:33:24.521711214 +0100 > @@ -116,8 +116,8 @@ static void serport_ldisc_close(struct t > > /* > * serport_ldisc_receive() is called by the low level tty driver when characters > - * are ready for us. We forward the characters, one by one to the 'interrupt' > - * routine. > + * are ready for us. We forward the characters and flags, one by one to the > + * 'interrupt' routine. > */ > > static void serport_ldisc_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, int count) > @@ -132,7 +132,7 @@ static void serport_ldisc_receive(struct > goto out; > > for (i = 0; i < count; i++) > - serio_interrupt(serport->serio, cp[i], 0); > + serio_interrupt(serport->serio, cp[i], fp[i]); > Hi David, The flags argument that serio_interrupt() accepts not the raw protocol data, but sanitized, protocol-independent SERIO_TIMEOUT, SERIO_PARITY and SERIO_FRAME bits. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serio: allow registered drivers to get status flag 2011-01-18 19:57 ` Dmitry Torokhov @ 2011-01-20 9:05 ` David Engraf 2011-01-26 9:36 ` David Engraf 0 siblings, 1 reply; 5+ messages in thread From: David Engraf @ 2011-01-20 9:05 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: linux-input, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1651 bytes --] Am 18.01.2011 20:57, schrieb Dmitry Torokhov: > On Tue, Jan 18, 2011 at 01:57:21PM +0100, David Engraf wrote: >> Parse the status byte information to the registered serio drivers as >> well as the character bytes. >> >> Signed-off-by: David Engraf<david.engraf@sysgo.com> >> > >> --- linux-2.6.37/drivers/input/serio/serport.c.orig 2011-01-18 12:33:41.421709232 +0100 >> +++ linux-2.6.37/drivers/input/serio/serport.c 2011-01-18 13:33:24.521711214 +0100 >> @@ -116,8 +116,8 @@ static void serport_ldisc_close(struct t >> >> /* >> * serport_ldisc_receive() is called by the low level tty driver when characters >> - * are ready for us. We forward the characters, one by one to the 'interrupt' >> - * routine. >> + * are ready for us. We forward the characters and flags, one by one to the >> + * 'interrupt' routine. >> */ >> >> static void serport_ldisc_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, int count) >> @@ -132,7 +132,7 @@ static void serport_ldisc_receive(struct >> goto out; >> >> for (i = 0; i< count; i++) >> - serio_interrupt(serport->serio, cp[i], 0); >> + serio_interrupt(serport->serio, cp[i], fp[i]); >> > > Hi David, > > The flags argument that serio_interrupt() accepts not the raw protocol > data, but sanitized, protocol-independent SERIO_TIMEOUT, SERIO_PARITY > and SERIO_FRAME bits. > > Thanks. > Hi Dmitry, I've updated the patch so that the raw protocol is converted to the SERIO_ bits. The raw protocol can parse only one flag, so I don't need to store multiple SERIO_ bits in the character flag variable. Thanks - David Signed-off-by: David Engraf<david.engraf@sysgo.com> [-- Attachment #2: serport_parse_flags.diff --] [-- Type: text/x-diff, Size: 1282 bytes --] --- linux-2.6.37/drivers/input/serio/serport.c.orig 2011-01-18 12:33:41.421709232 +0100 +++ linux-2.6.37/drivers/input/serio/serport.c 2011-01-20 09:55:53.849550065 +0100 @@ -116,14 +116,15 @@ static void serport_ldisc_close(struct t /* * serport_ldisc_receive() is called by the low level tty driver when characters - * are ready for us. We forward the characters, one by one to the 'interrupt' - * routine. + * are ready for us. We forward the characters and flags, one by one to the + * 'interrupt' routine. */ static void serport_ldisc_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, int count) { struct serport *serport = (struct serport*) tty->disc_data; unsigned long flags; + unsigned int ch_flags; int i; spin_lock_irqsave(&serport->lock, flags); @@ -131,8 +132,15 @@ static void serport_ldisc_receive(struct if (!test_bit(SERPORT_ACTIVE, &serport->flags)) goto out; - for (i = 0; i < count; i++) - serio_interrupt(serport->serio, cp[i], 0); + for (i = 0; i < count; i++) { + ch_flags = 0; + if (fp[i] == TTY_FRAME) + ch_flags = SERIO_FRAME; + else if (fp[i] == TTY_PARITY) + ch_flags = SERIO_PARITY; + + serio_interrupt(serport->serio, cp[i], ch_flags); + } out: spin_unlock_irqrestore(&serport->lock, flags); ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serio: allow registered drivers to get status flag 2011-01-20 9:05 ` David Engraf @ 2011-01-26 9:36 ` David Engraf 2011-01-26 17:00 ` Dmitry Torokhov 0 siblings, 1 reply; 5+ messages in thread From: David Engraf @ 2011-01-26 9:36 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: linux-input, linux-kernel Am 20.01.2011 10:05, schrieb David Engraf: > Am 18.01.2011 20:57, schrieb Dmitry Torokhov: >> On Tue, Jan 18, 2011 at 01:57:21PM +0100, David Engraf wrote: >>> Parse the status byte information to the registered serio drivers as >>> well as the character bytes. >>> >>> Signed-off-by: David Engraf<david.engraf@sysgo.com> >>> >> >>> --- linux-2.6.37/drivers/input/serio/serport.c.orig 2011-01-18 >>> 12:33:41.421709232 +0100 >>> +++ linux-2.6.37/drivers/input/serio/serport.c 2011-01-18 >>> 13:33:24.521711214 +0100 >>> @@ -116,8 +116,8 @@ static void serport_ldisc_close(struct t >>> >>> /* >>> * serport_ldisc_receive() is called by the low level tty driver when >>> characters >>> - * are ready for us. We forward the characters, one by one to the >>> 'interrupt' >>> - * routine. >>> + * are ready for us. We forward the characters and flags, one by one >>> to the >>> + * 'interrupt' routine. >>> */ >>> >>> static void serport_ldisc_receive(struct tty_struct *tty, const >>> unsigned char *cp, char *fp, int count) >>> @@ -132,7 +132,7 @@ static void serport_ldisc_receive(struct >>> goto out; >>> >>> for (i = 0; i< count; i++) >>> - serio_interrupt(serport->serio, cp[i], 0); >>> + serio_interrupt(serport->serio, cp[i], fp[i]); >>> >> >> Hi David, >> >> The flags argument that serio_interrupt() accepts not the raw protocol >> data, but sanitized, protocol-independent SERIO_TIMEOUT, SERIO_PARITY >> and SERIO_FRAME bits. >> >> Thanks. >> > > Hi Dmitry, > > I've updated the patch so that the raw protocol is converted to the > SERIO_ bits. The raw protocol can parse only one flag, so I don't need > to store multiple SERIO_ bits in the character flag variable. > > Thanks > - David > > > Signed-off-by: David Engraf<david.engraf@sysgo.com> > Hi Dmitry, is my last patch okay for you? Just want to know if I can give you further help on this and if it is planned to integrate my patch. Thanks - David ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serio: allow registered drivers to get status flag 2011-01-26 9:36 ` David Engraf @ 2011-01-26 17:00 ` Dmitry Torokhov 0 siblings, 0 replies; 5+ messages in thread From: Dmitry Torokhov @ 2011-01-26 17:00 UTC (permalink / raw) To: David Engraf; +Cc: linux-input, linux-kernel On Wed, Jan 26, 2011 at 10:36:42AM +0100, David Engraf wrote: > Am 20.01.2011 10:05, schrieb David Engraf: > >Am 18.01.2011 20:57, schrieb Dmitry Torokhov: > >>On Tue, Jan 18, 2011 at 01:57:21PM +0100, David Engraf wrote: > >>>Parse the status byte information to the registered serio drivers as > >>>well as the character bytes. > >>> > >>>Signed-off-by: David Engraf<david.engraf@sysgo.com> > >>> > >> > >>>--- linux-2.6.37/drivers/input/serio/serport.c.orig 2011-01-18 > >>>12:33:41.421709232 +0100 > >>>+++ linux-2.6.37/drivers/input/serio/serport.c 2011-01-18 > >>>13:33:24.521711214 +0100 > >>>@@ -116,8 +116,8 @@ static void serport_ldisc_close(struct t > >>> > >>>/* > >>>* serport_ldisc_receive() is called by the low level tty driver when > >>>characters > >>>- * are ready for us. We forward the characters, one by one to the > >>>'interrupt' > >>>- * routine. > >>>+ * are ready for us. We forward the characters and flags, one by one > >>>to the > >>>+ * 'interrupt' routine. > >>>*/ > >>> > >>>static void serport_ldisc_receive(struct tty_struct *tty, const > >>>unsigned char *cp, char *fp, int count) > >>>@@ -132,7 +132,7 @@ static void serport_ldisc_receive(struct > >>>goto out; > >>> > >>>for (i = 0; i< count; i++) > >>>- serio_interrupt(serport->serio, cp[i], 0); > >>>+ serio_interrupt(serport->serio, cp[i], fp[i]); > >>> > >> > >>Hi David, > >> > >>The flags argument that serio_interrupt() accepts not the raw protocol > >>data, but sanitized, protocol-independent SERIO_TIMEOUT, SERIO_PARITY > >>and SERIO_FRAME bits. > >> > >>Thanks. > >> > > > >Hi Dmitry, > > > >I've updated the patch so that the raw protocol is converted to the > >SERIO_ bits. The raw protocol can parse only one flag, so I don't need > >to store multiple SERIO_ bits in the character flag variable. > > > >Thanks > >- David > > > > > >Signed-off-by: David Engraf<david.engraf@sysgo.com> > > > > Hi Dmitry, > > is my last patch okay for you? Just want to know if I can give you > further help on this and if it is planned to integrate my patch. > Hi David, The patch should hit mainline real soon now, no action is needed on your part. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-26 17:00 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-01-18 12:57 [PATCH] serio: allow registered drivers to get status flag David Engraf 2011-01-18 19:57 ` Dmitry Torokhov 2011-01-20 9:05 ` David Engraf 2011-01-26 9:36 ` David Engraf 2011-01-26 17:00 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).