From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Ross Subject: Re: [PATCH 0/4] Pegatron Lucid tablet acceleromter/ALS Date: Tue, 25 Jan 2011 08:43:59 -0800 Message-ID: <4D3EFDCF.7090308@windriver.com> References: <1295909288-32650-1-git-send-email-andy.ross@windriver.com> <20110124230557.GA18135@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org To: Corentin Chary Cc: Dmitry Torokhov , linux-input@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org List-Id: linux-input@vger.kernel.org On 01/24/2011 11:30 PM, Corentin Chary wrote: > Dmitry Torokhov wrote: > > I am happy with the input part but I wonder if it really needs to be > > separate? If you roll it up into asus-laptop you would not need a new > > platform device and then it would be what - 20 lines of code? > > > > Corentin, what do you think? > > I think that it should be consistent, if there is already some code > for pegatron tablet in asus-laptop, then why a new platform device > only for the accelerometer ? No strong feelings here. I made it a separate file because asus-laptop.c is already very large and this was something that could be fairly easily split out, but obviously it's a really trivial device. > Andy, what is shared with asus-laptop exactly ? What sysfs files are > working and enabled ? Are backlight and led classes working ? Just the key device, which exports the single touch area in the corner of the tablet as KEY_MEDIA. Some of the other sysfs devices (bluetooth, display, leds) appear because the methods exist, but they're stubbed out in the ASL and thus noops. Andy