From: Igor Grinberg <grinberg@compulab.co.il>
To: "Poddar, Sourav" <sourav.poddar@ti.com>
Cc: dmitry.torokhov@gmail.com, balbi@ti.com,
Kishon Vijay Abraham I <kishon@ti.com>,
charu@ti.com, linux-input@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
gadiyar@ti.com
Subject: Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup
Date: Thu, 03 Feb 2011 13:12:32 +0200 [thread overview]
Message-ID: <4D4A8DA0.1010806@compulab.co.il> (raw)
In-Reply-To: <AANLkTi=U1qo=udB=tMyuA2HcnCS4EmreaVDbw2vQ9dY8@mail.gmail.com>
On 02/03/11 13:00, Poddar, Sourav wrote:
> On Thu, Feb 3, 2011 at 3:47 PM, Igor Grinberg <grinberg@compulab.co.il> wrote:
>> if (pdata->get_pendown_state) {
>> ts->get_pendown_state = pdata->get_pendown_state;
>> ts->gpio_pendown = -1;
>> return 0;
>> }
> Yes we can do so .I initialise it at a place where other variables
> where initialised.
>
>>> Also, why don't we use -EINVAL for the invalid gpio number instead of -1 constant?
>>>
> I used -1 because conditional check done in probe ads7846_probe function
> used this value.
>
> err_free_gpio:
> if (ts->gpio_pendown != -1)
> gpio_free(ts->gpio_pendown);
>
Well I understand that and that's why in my proposal I used -1 also, but
I thought we can make it even better if we switch to -EINVAL
(though wanted to check if there are any reasonable objections)
and while you are at this, may be you are willing also to submit a patch for this?
--
Regards,
Igor.
next prev parent reply other threads:[~2011-02-03 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 9:48 [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup Sourav Poddar
2011-02-03 10:10 ` Igor Grinberg
2011-02-03 10:17 ` Igor Grinberg
2011-02-03 11:00 ` Poddar, Sourav
2011-02-03 11:09 ` Felipe Balbi
2011-02-03 11:12 ` Igor Grinberg [this message]
2011-02-03 11:28 ` ABRAHAM, KISHON VIJAY
2011-02-03 13:00 ` Igor Grinberg
2011-02-03 11:32 ` Lothar Waßmann
2011-02-03 11:40 ` Poddar, Sourav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4A8DA0.1010806@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=balbi@ti.com \
--cc=charu@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gadiyar@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).