From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Abraham Arce <x0066660@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v8 3/3] OMAP4:keypad: PM runtime
Date: Wed, 23 Feb 2011 19:49:33 +0530 [thread overview]
Message-ID: <4D651775.8030308@ti.com> (raw)
In-Reply-To: <20110223062900.GB19269@core.coreip.homeip.net>
On Wednesday 23 February 2011 11:59 AM, Dmitry Torokhov wrote:
> On Sat, Feb 19, 2011 at 01:44:32PM +0530, Datta, Shubhrajyoti wrote:
>> On Sat, Feb 19, 2011 at 11:01 AM, Dmitry Torokhov<dmitry.torokhov@gmail.com
>>> wrote:
>>> Hi Shubhrajyoti,
>>>
>>> On Sat, Feb 19, 2011 at 08:37:15AM +0530, Shubhrajyoti wrote:
>>>> Hello Dmitry,
>>>> If there are no further comments.
>>>> Can it be queued?
>>> I normally try not to merge board code leaving it to arch owner. Can we
>>> at least get arch/board maintainer ACKs on this?
>>>
>>> Also, I am wondering, what is the utility of this patch? Without it,
>>> as far as I understand, runtime PM is disabled for the device. With the
>>> patch we enable runtime PM but immediately bump up usage count, thus
>>> ensuring that the device is always powered on. So what changed? Or am I
>>> missing something?
>>>
>> After the hwmod changes the clocks are cut. So if it is not enabled then the
>> device is not usable.
>>
> OK, that makes sense. So since we are wiring up runtime PM I think we
> should go a strep further and do it in open/close methods. Does the
> patch below still work for you?
Yes it works I did some basic testinig it on omap4 sdp. Thanks
> Thanks.
>
next prev parent reply other threads:[~2011-02-23 14:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 5:51 [PATCH 0/3]OMAP4: Keypad support shubhrajyoti
2010-12-27 5:51 ` [PATCH v8 1/3] OMAP4: hwmod data: Add keypad in the hwmod database shubhrajyoti
2010-12-27 5:51 ` [PATCH v8 2/3] OMAP4: keypad: Add the board support shubhrajyoti
2010-12-27 5:51 ` [PATCH v8 3/3] OMAP4:keypad: PM runtime shubhrajyoti
2011-02-08 8:30 ` Shubhrajyoti
2011-02-11 17:18 ` Shubhrajyoti
2011-02-19 3:07 ` Shubhrajyoti
2011-02-19 5:31 ` Dmitry Torokhov
[not found] ` <AANLkTikCmiSrOZb3WvMZHcxRsSRxd1zUsWE59aexHdeF@mail.gmail.com>
2011-02-23 6:29 ` Dmitry Torokhov
2011-02-23 14:19 ` Shubhrajyoti [this message]
2011-02-23 22:58 ` Tony Lindgren
2011-02-23 23:12 ` Dmitry Torokhov
2011-02-15 9:41 ` [PATCH 0/3]OMAP4: Keypad support Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D651775.8030308@ti.com \
--to=shubhrajyoti@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).