From: Jonathan Cameron <jic23@cam.ac.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Add a driver to support InvenSense mpu3050 gyroscope chip.
Date: Tue, 15 Mar 2011 11:59:30 +0000 [thread overview]
Message-ID: <4D7F54A2.2020501@cam.ac.uk> (raw)
In-Reply-To: <20110315060203.GF1046@core.coreip.homeip.net>
On 03/15/11 06:02, Dmitry Torokhov wrote:
> Hi Alan,
>
> On Wed, Mar 09, 2011 at 01:47:51PM +0000, Alan Cox wrote:
>> From: Joseph Lai <joseph_lai@wistron.com>
>>
>> This driver is registered as an input device with sysfs control
>> interface, but it still can output 3 axes data in non-interrupt mode.
>>
>> This is primarily an input device but can also be used as for other things.
>> It thus exposes the power control (so you can keep power on when you want) and
>> x/y/z co-ordinates directly.
>
> I'd be more happy if it was just an input device. If non-wired interrupt
> is a common case then we should probably add polled input device mode,
> but we certainly should not register completely non-functional input
> device as the driver does now.
>
> We also have a way of retrieving current (or rather most recent)
> coordinates via EVIOCGABS so I am not sure why we want the sysfs way of
> retrieving coordinates as well.
>
> Regarding power mode - I really believe that this should be done on the
> driver core level instead of implementing "manual off" in every single
> driver out there.
definitely. Know anyone with the time / inclination to get that added?
next prev parent reply other threads:[~2011-03-15 11:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 13:47 [PATCH] Add a driver to support InvenSense mpu3050 gyroscope chip Alan Cox
2011-03-14 15:39 ` Jonathan Cameron
2011-03-14 18:24 ` Alan Cox
2011-03-14 19:29 ` Jonathan Cameron
2011-03-14 20:14 ` Alan Cox
2011-03-15 6:02 ` Dmitry Torokhov
2011-03-15 11:59 ` Jonathan Cameron [this message]
2011-03-15 12:58 ` Alan Cox
2011-03-16 6:30 ` Dmitry Torokhov
2011-03-16 21:07 ` Rafael J. Wysocki
2011-03-15 9:44 ` Shubhrajyoti
-- strict thread matches above, loose matches on Subject: below --
2011-04-06 12:38 Alan Cox
2011-04-13 9:51 Alan Cox
2011-04-13 10:30 ` Jonathan Cameron
2011-04-13 13:07 ` Alan Cox
2011-04-13 14:21 ` Jonathan Cameron
2011-04-13 14:30 ` Hennerich, Michael
2011-04-13 14:46 ` Alan Cox
2011-04-13 15:03 ` simon
2011-04-13 14:54 ` Alan Cox
2011-04-13 15:21 ` simon
2011-04-13 14:55 Alan Cox
2011-04-13 14:58 Alan Cox
2011-04-13 15:54 ` Jonathan Cameron
2011-05-04 9:02 Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7F54A2.2020501@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).