From: Michael Hennerich <michael.hennerich@analog.com>
To: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Barry Song <21cnbao@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: ad714x driver help and possible bug
Date: Fri, 29 Apr 2011 16:58:39 +0200 [thread overview]
Message-ID: <4DBAD21F.7040406@analog.com> (raw)
In-Reply-To: <4DBAD0AC.3010608@analog.com>
On 04/29/2011 04:52 PM, Michael Hennerich wrote:
> On 04/29/2011 11:55 AM, Jonathan Cameron wrote:
>> Cc'd input, and analog devices driver list...
>>
>> On 04/28/11 19:17, Jean-Francois Dagenais wrote:
>>
>>
>>> I also had to change the request_threaded_irq flags to specify
>>> IRQF_ONESHOT so the kernel keeps the interrupt masked while we are
>>> running ad714x_interrupt_thread(). Otherwise we were getting storms
>>> of interrupts each time only one was requested. I am wondering if
>>> this should be pulled back to the mainline kernel?
>>>
>>> Thanks for pointers and clues!
>>>
>>>
> I assume this is due to the fact that the interrupt on the host is
> level sensitive.
> In this case you need to use the IRQF_ONESHOT flag.
> The unmodified driver requests the IRQ as IRQF_TRIGGER_FALLING, so
> this is not necessary.
>
> To my knowledge we regularly test the driver with the sliders, wheels
> and buttons found on the
> official evaluation board, and so far we haven't found oddities.
> For an example platform file see: arch/blackfin/mach-bf537/boards/stamp.c
> From top of my head I don't know whether we're testing with the SPI or
> I2C interface.
>
> http://wiki.analog.com/software/driver/linux/ad714x
>
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
next prev parent reply other threads:[~2011-04-29 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <62821D7C-1637-4F7E-A53A-F52AEB2A6C87@gmail.com>
2011-04-29 9:55 ` ad714x driver help and possible bug Jonathan Cameron
[not found] ` <4DBAD0AC.3010608@analog.com>
2011-04-29 14:58 ` Michael Hennerich [this message]
2011-05-02 20:43 ` Jean-Francois Dagenais
2011-05-03 14:13 ` Jean-Francois Dagenais
[not found] ` <A89A87E2-E4C4-4DD7-9E51-9FD38D93DC0E@gmail.com>
2011-05-03 14:33 ` Michael Hennerich
2011-05-03 15:16 ` Michael Hennerich
2011-05-03 23:50 ` Jean-François Dagenais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBAD21F.7040406@analog.com \
--to=michael.hennerich@analog.com \
--cc=21cnbao@gmail.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=jeff.dagenais@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).