Re: 35022: hid-magicmouse broken

[Chase Douglas <chase.douglas@canonical.com>]

On 05/17/2011 08:56 AM, Jiri Kosina wrote:
> On Tue, 17 May 2011, Chase Douglas wrote:
> 
>> Hi Jiri,
>>
>> I've received a few emails about the magicmouse driver being broken on
>> 2.6.39:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=35022
>>
>> It seems hid_output_raw_report() is returning a different (incorrect?)
>> value than in the past. Do you know what might be going on?
> 
> So we are getting EIO from the transport-level _raw callback.
> 
> Hmm, commit 0825411ade seems like a suspect here. Might be possible that 
> magicmouse doesn't send ACK back, right?
> 
> Could you please try reverting that commit and re-test?

Yes, reverting that commit makes it work.

I'm just speculating here, based on commit message names and what you've
said, that the magicmouse is not protocol compliant because it is not
sending an ACK back? What do you think we should do in the driver?
Should we ignore the return, or should we look specifically for EIO?
(neither sounds very good to me, so I'm hoping you have a better
solution :).

Thanks!

-- Chase