From: Ike Panhc <ike.pan@canonical.com>
To: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: Matthew Garrett <mjg@redhat.com>,
Dmitry Torohov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] ideapad: let Fn+F5 also trigger KEY_BLUETOOTH
Date: Tue, 14 Jun 2011 16:29:53 +0800 [thread overview]
Message-ID: <4DF71C01.6080504@canonical.com> (raw)
In-Reply-To: <1308040109-12038-1-git-send-email-ike.pan@canonical.com>
On 06/14/2011 04:28 PM, Ike Panhc wrote:
> The design for ideapad Fn-F5 key is not only for wifi but for all
> radio device including wifi, bluetooth and wwan. Idealy it shall
> acts like this:
>
> wifi on wifi off wifi on wifi off
> bt on -----> bt on -----> bt off -----> bt off
>
> This patch will switch wifi mode every key-push and switch
> bluetooth mode every two key-push.
This maybe is disputed.
The problem is that now Fn+F5 only turns on/off wifi and leave bluetooth alone.
According to the design this hotkey shall change the status of all radio
devices, including wifi, bluetooth and wwan.
On machine with wifi and bluetooth, it will turn on/off wifi and bluetooth in
order. On machine with wifi, it will switch wifi mode on every event.
I think it is better to solve this in driver not in user space application
because on some other platforms, the KEY_WLAN and KEY_BLUETOOTH are separate.
I do not have a clear idea how to deal with wwan interface such as it shall be
exclusive or inclusive with wifi.
Please reply for any opinion.
next prev parent reply other threads:[~2011-06-14 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 8:28 [PATCH] ideapad: let Fn+F5 also trigger KEY_BLUETOOTH Ike Panhc
2011-06-14 8:29 ` Ike Panhc [this message]
2011-06-14 9:08 ` David Woodhouse
2011-06-14 9:21 ` Bastien Nocera
2011-06-14 21:52 ` Joey Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF71C01.6080504@canonical.com \
--to=ike.pan@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).