From: Anirudh Ghayal <aghayal@codeaurora.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Trilok Soni <tsoni@codeaurora.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: pmic8xxx-keypad - fix a leak of the IRQ during init failure
Date: Thu, 14 Jul 2011 11:54:56 +0530 [thread overview]
Message-ID: <4E1E8BB8.2060809@codeaurora.org> (raw)
In-Reply-To: <1310609391.14393.1.camel@phoenix>
On 7/14/2011 7:39 AM, Axel Lin wrote:
> Make sure we are passing the same cookie in all calls to
> request_any_context_irq() and free_irq().
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
Acked-by: Anirudh Ghayal <aghayal@codeaurora.org>
> ---
> drivers/input/keyboard/pmic8xxx-keypad.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c
> index 6229c3e..e7cc51d 100644
> --- a/drivers/input/keyboard/pmic8xxx-keypad.c
> +++ b/drivers/input/keyboard/pmic8xxx-keypad.c
> @@ -700,9 +700,9 @@ static int __devinit pmic8xxx_kp_probe(struct platform_device *pdev)
> return 0;
>
> err_pmic_reg_read:
> - free_irq(kp->key_stuck_irq, NULL);
> + free_irq(kp->key_stuck_irq, kp);
> err_req_stuck_irq:
> - free_irq(kp->key_sense_irq, NULL);
> + free_irq(kp->key_sense_irq, kp);
> err_gpio_config:
> err_get_irq:
> input_free_device(kp->input);
> @@ -717,8 +717,8 @@ static int __devexit pmic8xxx_kp_remove(struct platform_device *pdev)
> struct pmic8xxx_kp *kp = platform_get_drvdata(pdev);
>
> device_init_wakeup(&pdev->dev, 0);
> - free_irq(kp->key_stuck_irq, NULL);
> - free_irq(kp->key_sense_irq, NULL);
> + free_irq(kp->key_stuck_irq, kp);
> + free_irq(kp->key_sense_irq, kp);
> input_unregister_device(kp->input);
> kfree(kp);
>
prev parent reply other threads:[~2011-07-14 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 2:09 [PATCH] Input: pmic8xxx-keypad - fix a leak of the IRQ during init failure Axel Lin
2011-07-14 6:24 ` Anirudh Ghayal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1E8BB8.2060809@codeaurora.org \
--to=aghayal@codeaurora.org \
--cc=axel.lin@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).