From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanlong Gao Subject: Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys Date: Tue, 26 Jul 2011 14:25:48 +0800 Message-ID: <4E2E5DEC.60208@cn.fujitsu.com> References: <20110725083048.GD22937@core.coreip.homeip.net> <4E2D33E3.9090408@cn.fujitsu.com> <20110725152106.GB23356@suse.de> <1311608069.3262.8.camel@Allen> <20110725181916.GB6876@core.coreip.homeip.net> <20110725182928.GB1175@sirena.org.uk> <20110725183746.GD6876@core.coreip.homeip.net> <4E2E1897.9020808@cn.fujitsu.com> <20110726043949.GA27720@suse.de> <4E2E5240.4060309@cn.fujitsu.com> <20110726060248.GA3868@suse.de> Reply-To: gaowanlong@cn.fujitsu.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:51075 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751293Ab1GZG0r (ORCPT ); Tue, 26 Jul 2011 02:26:47 -0400 In-Reply-To: <20110726060248.GA3868@suse.de> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Greg KH Cc: Dmitry Torokhov , Mark Brown , Wanlong Gao , linux-input@vger.kernel.org On 07/26/2011 02:02 PM, Greg KH wrote: > On Tue, Jul 26, 2011 at 01:36:00PM +0800, Wanlong Gao wrote: >> On 07/26/2011 12:39 PM, Greg KH wrote: >> >>>> + >>>> + if (drv->remove) { >>>> + dev_dbg(_dev, "remove\n"); >>>> + status = drv->remove(dev); >>>> + } else { >>>> + status = 0; >>>> + } >>> >>> Again, why would remove ever be NULL? >>> >>> This whole thing isn't needed at all. >>> >>> greg k-h >> Yeah, I see. >> >> But Greg, why does i2c-core do this? >> like:drivers/i2c/i2c-core.c: > > The i2c core has different requirements than the driver core does, > right? They are two totally different things, please don't assume that > the rules for one are the same for the other. > > greg k-h > Hmm...They are totally different things, maybe I see.. -- Thanks Best Regards Wanlong Gao