From: Chase Douglas <chase.douglas@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: djkurtz@chromium.org, rydberg@euromail.se, rubini@cvml.unipv.it,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
derek.foreman@collabora.co.uk, daniel.stone@collabora.co.uk,
olofj@chromium.org
Subject: Re: [PATCH 1/9 v2] Input: synaptics - refactor y inversion
Date: Tue, 26 Jul 2011 15:59:33 -0700 [thread overview]
Message-ID: <4E2F46D5.6060206@canonical.com> (raw)
In-Reply-To: <20110725082752.GB22937@core.coreip.homeip.net>
On 07/25/2011 01:27 AM, Dmitry Torokhov wrote:
> On Wed, Jul 20, 2011 at 09:38:58PM +0800, djkurtz@chromium.org wrote:
>> From: Daniel Kurtz <djkurtz@chromium.org>
>>
>> Synaptics touchpads report increasing y from bottom to top.
>> This is inverted from normal userspace "top of screen is 0" coordinates.
>> Thus, the kernel driver reports inverted y coordinates to userspace.
>>
>> This patch refactors this inversion.
>>
>
> I really do not see the point...
It's easier for me to read and comprehend, at least. I agree that it's
really really minor, but if it's in the middle of 10 other patches, then
I don't have a problem with it.
-- Chase
next prev parent reply other threads:[~2011-07-26 22:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 13:38 [PATCH 0/9 v2] Synaptics image sensor support djkurtz
2011-07-20 13:38 ` [PATCH 1/9 v2] Input: synaptics - refactor y inversion djkurtz
2011-07-23 0:30 ` Chase Douglas
2011-07-25 8:27 ` Dmitry Torokhov
2011-07-26 2:19 ` Daniel Kurtz
2011-07-26 22:59 ` Chase Douglas [this message]
2011-07-20 13:38 ` [PATCH 2/9 v2] Input: synaptics - refactor agm packet parsing djkurtz
2011-07-23 0:32 ` Chase Douglas
2011-07-20 13:39 ` [PATCH 3/9 v2] Input: synaptics - refactor initialization of abs position axes djkurtz
2011-07-23 0:36 ` Chase Douglas
2011-07-20 13:39 ` [PATCH 4/9 v2] Input: synaptics - add image sensor support djkurtz
2011-07-20 13:39 ` [PATCH 5/9 v2] Input: synaptics - decode AGM packet types djkurtz
2011-07-20 13:39 ` [PATCH 6/9 v2] Input: synaptics - process finger (<=3) transitions djkurtz
2011-07-23 1:11 ` Chase Douglas
2011-07-20 13:39 ` [PATCH 7/9 v2] Input: synaptics - improved 2->3 finger transition handling djkurtz
2011-07-23 1:07 ` Chase Douglas
2011-07-23 4:36 ` Daniel Kurtz
2011-07-26 23:14 ` Chase Douglas
2011-07-27 4:48 ` Daniel Kurtz
2011-07-27 21:13 ` Chase Douglas
2011-07-28 1:00 ` Daniel Kurtz
2011-07-28 2:07 ` Chase Douglas
2011-07-28 13:56 ` Daniel Kurtz
2011-07-28 17:31 ` Chase Douglas
2011-07-20 13:39 ` [PATCH 8/9 v2] Input: add BTN_TOOL_QUINTTAP for reporting 5 fingers on touchpad djkurtz
2011-07-23 0:59 ` Chase Douglas
2011-07-25 8:29 ` Dmitry Torokhov
2011-07-25 9:14 ` Daniel Kurtz
2011-07-25 18:16 ` Dmitry Torokhov
2011-07-26 2:18 ` Daniel Kurtz
2011-08-11 20:07 ` Henrik Rydberg
2011-07-26 23:03 ` Chase Douglas
2011-07-20 13:39 ` [PATCH 9/9 v2] Input: synaptics - process finger (<=5) transitions djkurtz
2011-07-23 1:02 ` Chase Douglas
2011-07-23 4:11 ` Daniel Kurtz
2011-07-26 23:17 ` Chase Douglas
2011-07-23 1:13 ` [PATCH 0/9 v2] Synaptics image sensor support Chase Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2F46D5.6060206@canonical.com \
--to=chase.douglas@canonical.com \
--cc=daniel.stone@collabora.co.uk \
--cc=derek.foreman@collabora.co.uk \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=rubini@cvml.unipv.it \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).