From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Andrew Drake <adrake@adrake.org>
Cc: linux-input@vger.kernel.org, rydberg@euromail.se
Subject: Re: [PATCH] input: bcm5974: Add support for newer MacBookPro8,2
Date: Tue, 16 Aug 2011 16:21:26 +0800 [thread overview]
Message-ID: <4E4A2886.8080805@cn.fujitsu.com> (raw)
In-Reply-To: <4E4A24CC.6000909@adrake.org>
On 08/16/2011 04:05 PM, Andrew Drake wrote:
> On 08/16/2011 12:13 AM, Wanlong Gao wrote:
>> On 08/16/2011 02:20 PM, Andrew Drake wrote:
>>> I just received a new MacBook Pro, product name MacBookPro8,2. It came
>>> with a newer/higher resolution touchpad than others with the same
>>> product name with USB ID 05ac:0252. The following patch (which applies
>>> on top of 3.1-rc2) adds support for this device.
>>>
>>> <snip>
>> I wonder that why can't I apply this patch?
>> #git am<[path]>
>> Applying: input: bcm5974: Add support for newer MacBookPro8,2
>> fatal: corrupt patch at line 32
>> Patch failed at 0001 input: bcm5974: Add support for newer MacBookPro8,2
>>
>
> Sorry, my mailer wrapped some of the lines. Try this:
>
>
> Signed-off-by: Andrew Drake<adrake@adrake.org>
> ---
> drivers/input/mouse/bcm5974.c | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
> index 3126983..a0a4964 100644
> --- a/drivers/input/mouse/bcm5974.c
> +++ b/drivers/input/mouse/bcm5974.c
> @@ -67,6 +67,10 @@
> #define USB_DEVICE_ID_APPLE_WELLSPRING5_ANSI 0x0245
> #define USB_DEVICE_ID_APPLE_WELLSPRING5_ISO 0x0246
> #define USB_DEVICE_ID_APPLE_WELLSPRING5_JIS 0x0247
> +/* Macbook8,2 (unibody) */
> +#define USB_DEVICE_ID_APPLE_WELLSPRING5A_ANSI 0x0252
> +#define USB_DEVICE_ID_APPLE_WELLSPRING5A_ISO 0x0253
> +#define USB_DEVICE_ID_APPLE_WELLSPRING5A_JIS 0x0254
>
> #define BCM5974_DEVICE(prod) { \
> .match_flags = (USB_DEVICE_ID_MATCH_DEVICE | \
> @@ -104,6 +108,10 @@ static const struct usb_device_id bcm5974_table[] = {
> BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING5_ANSI),
> BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING5_ISO),
> BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING5_JIS),
> + /* MacbookPro8,2 */
> + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING5A_ANSI),
> + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING5A_ISO),
> + BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING5A_JIS),
> /* Terminating entry */
> {}
> };
> @@ -294,6 +302,18 @@ static const struct bcm5974_config bcm5974_config_table[] = {
> { DIM_X, DIM_X / SN_COORD, -4415, 5050 },
> { DIM_Y, DIM_Y / SN_COORD, -55, 6680 }
> },
> + {
> + USB_DEVICE_ID_APPLE_WELLSPRING5A_ANSI,
> + USB_DEVICE_ID_APPLE_WELLSPRING5A_ISO,
> + USB_DEVICE_ID_APPLE_WELLSPRING5A_JIS,
> + HAS_INTEGRATED_BUTTON,
> + 0x84, sizeof(struct bt_data),
> + 0x81, TYPE2, FINGER_TYPE2, FINGER_TYPE2 + SIZEOF_ALL_FINGERS,
> + { DIM_PRESSURE, DIM_PRESSURE / SN_PRESSURE, 0, 300 },
> + { DIM_WIDTH, DIM_WIDTH / SN_WIDTH, 0, 2048 },
> + { DIM_X, DIM_X / SN_COORD, -4750, 5280 },
> + { DIM_Y, DIM_Y / SN_COORD, -150, 6730 }
> + },
> {}
> };
>
Applying: input: bcm5974: Add support for newer MacBookPro8,2
error: patch failed: drivers/input/mouse/bcm5974.c:67
error: drivers/input/mouse/bcm5974.c: patch does not apply
Patch failed at 0001 input: bcm5974: Add support for newer MacBookPro8,2
--
Thanks
Wanlong Gao
next prev parent reply other threads:[~2011-08-16 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 6:20 [PATCH] input: bcm5974: Add support for newer MacBookPro8,2 Andrew Drake
2011-08-16 7:13 ` Wanlong Gao
2011-08-16 8:05 ` Andrew Drake
2011-08-16 8:21 ` Wanlong Gao [this message]
2011-08-16 8:31 ` Andrew Drake
2011-08-16 8:43 ` Wanlong Gao
2011-08-16 8:53 ` Wanlong Gao
2011-08-16 9:46 ` Andrew Drake
2011-08-16 10:01 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4A2886.8080805@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=adrake@adrake.org \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).